WP sends url-encoded text in pingback/trackback

[reinkim]

From [9012], WP sends trackback/pingback using urlencoded text.

[9012] introduces HTTP api to send trackback/pingback. But in this changeset, WP sends blog-title, uri and excerpt in url-encoded format.
So pinged/trackbacked blog displays some strangely formatted trackback like,

blog+title // title
http%3A%2F%2Fexample.org%2F111 // uri
blah+blah+blah+%23%21%40%23%24 // excerpt

This behavior is caused by passing arguments of HTTP api in urlencoded text. (wp-includes/comment.php:1312)

To fix this problem, I've patched current working version of trunk like following diff.

comment.php

@@ -1310 +1310 @@
    $options = array();
    $options['timeout'] = 4;
    $options['body'] = array(
-       'title' => urlencode($title),
-       'url' => urlencode(get_permalink($ID)),
-       'blog_name' => urlencode(get_option('blogname')),
-       'excerpt' => urlencode($excerpt)
+       'title' => $title,
+       'url' => get_permalink($ID),
+       'blog_name' => get_option('blogname'),
+       'excerpt' => $excerpt
    );

[reinkim]

Patch for wp-includes/comments.php

[ryan]

WP_Http::request() calls http_build_query() to encode the request so your patch looks correct.

[ryan]

(In [9292]) Don't double encode ping/trackbacks. Props reinkim. fixes #7844