"Unable to locate WordPress directory." on core update & PHPDoc for WP_Filesystem_Base

[DD32]

Attached patch does 2 things:

• Moves sanitization for windows paths around a bit
• Fixes trailing slash problems which caused "Unable to locate WordPress directory." on core upgrade attempts with FTP
• Added PHPDoc for most of the class functions. (Hopefully the docs are inline with the rest of WP..)

[DD32]

• PHPDoc also adds correct sources for the helper functions

[DD32]

attachment 7861.2.diff added.

• Adds a check for situations where the FTP account is rooted to the base of the WordPress install (Which some security concious people do, and some webhosts do(when WordPress is installed into the base of the public_html folder))

[azaozz]

(In [9117]) Fix for "Unable to locate WordPress directory" on core update and PHPDoc for class-wp-filesystem-base.php, props DD32, fixes #7861

[azaozz]

(In [9118]) Check if the FTP account is rooted to the base of the WordPress install, props DD32, see #7861

[DD32]

attachment 7861.3.diff added.

That fixes the issue outlined by Viper007Bond in #7872:

Downloading update from http://wordpress.org/nightly-builds/wordpress-latest.zip 
Unpacking the core update
Verifying the unpacked files
The update could not be unpacked
Installation Failed

[azaozz]

(In [9128]) Core update: fix for "The update could not be unpacked" error, props ShaneF, fixes #7861