![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 18 years ago
Closed 18 years ago
#7908 closed defect (bug) (fixed)
plugin install information dialog strips some valid HTML
| Reported by: | stephdau | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 2.7 |
| Component: | Administration | Version: | 2.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
Current svn status at time of reporting: r9225.
Context: Going through the process of installing a new plugin via the new built-in installer in WP 2.7 (trunk)
Error: the lightbox interface showing the plugin's information does not parse the plugin's readme file the same way that the regular wordpress.org interface does.
Example: backticks for preformatted text are not respected.
See attached screenshots for comparison.
Attachments (4)
Change History (15)
#2
@
18 years ago
- Summary Readme parser formatting errors in plugin install process → plugin install information dialog strips some valid HTML
The range of HTML which the plugin installer allows is currently limited, It seems i forgot to allow pre along with a few others:
http://trac.wordpress.org/browser/trunk/wp-admin/includes/plugin-install.php#L377
Can anyone think of other tags which need to be allowed?
#3
@
18 years ago
I'd suggest the ones allowed by http://wordpress.org/extend/plugins/about/validator/, if you can get access to the info.
Or covered in the standard readme: http://wordpress.org/extend/plugins/about/readme.txt
#4
@
18 years ago
if you can get access to the info.
The bbpress plugin used on wordpress.org/extend/ is on the bbpress plugin tracker somewhere, I'll go locate that again later and base it off that perhaps. I think <pre> might be one of the only tags missed.. (But it needs some more CSS for the display)
#6
@
18 years ago
- Keywords has-patch commit added
attachment 7908.diff added.
- Adds Pre to allowed tags
- Styles Pre and Code in fresh theme to same as wordpress.org
#7
@
18 years ago
(Oh, I found the bbPress plugin for wordpress.org, But couldnt find the readme parser, So i've possibly not covered *Every* possibility)
#9
@
18 years ago
- Keywords needs-patch added; has-patch commit removed
- Resolution fixed
- Status closed → reopened
Also, headers (ie. <h4>) need not be striped.
Lists may also need some extra styling and extra paddings.
Eg, Compare the cforms wordpress.org page to the builtin browser.
Note: backticks (`) are respected from a font-family perspective, but are not preformatted. See text underneath "This should result in something very similiar to the following file structure:" in screenshots.