plugin install information dialog strips some valid HTML

[stephdau]

Current svn status at time of reporting: r9225.

Context: Going through the process of installing a new plugin via the new built-in installer in WP 2.7 (trunk)

Error: the lightbox interface showing the plugin's information does not parse the plugin's readme file the same way that the regular wordpress.org interface does.

Example: backticks for preformatted text are not respected.

See attached screenshots for comparison.

[stephdau]

Note: backticks (`) are respected from a font-family perspective, but are not preformatted. See text underneath "This should result in something very similiar to the following file structure:" in screenshots.

[DD32]

The range of HTML which the plugin installer allows is currently limited, It seems i forgot to allow pre along with a few others:

​http://trac.wordpress.org/browser/trunk/wp-admin/includes/plugin-install.php#L377

Can anyone think of other tags which need to be allowed?

[stephdau]

I'd suggest the ones allowed by ​http://wordpress.org/extend/plugins/about/validator/, if you can get access to the info.

Or covered in the standard readme: ​http://wordpress.org/extend/plugins/about/readme.txt

[DD32]

if you can get access to the info.

The bbpress plugin used on wordpress.org/extend/ is on the bbpress plugin tracker somewhere, I'll go locate that again later and base it off that perhaps. I think <pre> might be one of the only tags missed.. (But it needs some more CSS for the display)

[DD32]

attachment 7908.diff added.

• Adds Pre to allowed tags
• Styles Pre and Code in fresh theme to same as wordpress.org

[DD32]

(Oh, I found the bbPress plugin for wordpress.org, But couldnt find the readme parser, So i've possibly not covered *Every* possibility)

[ryan]

(In [9314]) Plugin install dialog formatting fixes from DD32. fixes #7908

[DD32]

Also, headers (ie. <h4>) need not be striped.
Lists may also need some extra styling and extra paddings.

Eg, Compare the ​cforms wordpress.org page to the builtin browser.

[DD32]

attachment 7809.diff added.

• Adds h1-6 & img tags to the allowed list of HTML tags
• Adds some styling for Code blocks and lists.

[ryan]

(In [9682]) Plugin installer updates from DD32. fixes #7908