WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#7908 closed defect (bug) (fixed)

plugin install information dialog strips some valid HTML

Reported by: stephdau Owned by:
Milestone: 2.7 Priority: high
Severity: normal Version: 2.7
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Current svn status at time of reporting: r9225.

Context: Going through the process of installing a new plugin via the new built-in installer in WP 2.7 (trunk)

Error: the lightbox interface showing the plugin's information does not parse the plugin's readme file the same way that the regular wordpress.org interface does.

Example: backticks for preformatted text are not respected.

See attached screenshots for comparison.

Attachments (4)

BAD-installer-readme-formatting.png (104.8 KB) - added by stephdau 6 years ago.
GOOD-wordpress.org-readme-formatting.png (102.1 KB) - added by stephdau 6 years ago.
7908.diff (2.2 KB) - added by DD32 5 years ago.
7809.diff (2.4 KB) - added by DD32 5 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 stephdau6 years ago

Note: backticks (`) are respected from a font-family perspective, but are not preformatted. See text underneath "This should result in something very similiar to the following file structure:" in screenshots.

comment:2 DD326 years ago

  • Summary changed from Readme parser formatting errors in plugin install process to plugin install information dialog strips some valid HTML

The range of HTML which the plugin installer allows is currently limited, It seems i forgot to allow pre along with a few others:

http://trac.wordpress.org/browser/trunk/wp-admin/includes/plugin-install.php#L377

Can anyone think of other tags which need to be allowed?

comment:3 stephdau6 years ago

I'd suggest the ones allowed by http://wordpress.org/extend/plugins/about/validator/, if you can get access to the info.

Or covered in the standard readme: http://wordpress.org/extend/plugins/about/readme.txt

comment:4 DD326 years ago

if you can get access to the info.

The bbpress plugin used on wordpress.org/extend/ is on the bbpress plugin tracker somewhere, I'll go locate that again later and base it off that perhaps. I think <pre> might be one of the only tags missed.. (But it needs some more CSS for the display)

comment:5 ryan5 years ago

  • Priority changed from normal to high

DD325 years ago

comment:6 DD325 years ago

  • Keywords has-patch commit added

attachment 7908.diff added.

  • Adds Pre to allowed tags
  • Styles Pre and Code in fresh theme to same as wordpress.org

comment:7 DD325 years ago

(Oh, I found the bbPress plugin for wordpress.org, But couldnt find the readme parser, So i've possibly not covered *Every* possibility)

comment:8 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9314]) Plugin install dialog formatting fixes from DD32. fixes #7908

comment:9 DD325 years ago

  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Also, headers (ie. <h4>) need not be striped.
Lists may also need some extra styling and extra paddings.

Eg, Compare the cforms wordpress.org page to the builtin browser.

DD325 years ago

comment:10 DD325 years ago

  • Keywords has-patch added; needs-patch removed

attachment 7809.diff added.

  • Adds h1-6 & img tags to the allowed list of HTML tags
  • Adds some styling for Code blocks and lists.

comment:11 ryan5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9682]) Plugin installer updates from DD32. fixes #7908

Note: See TracTickets for help on using tickets.