Database upgrade complete message should be an admin notice

[westi]

When a database upgrade is complete we should just take you to the page you wanted to see and should an upgrade_complete admin notice instead of requiring another button click

[ryan]

The db_upgraded option that is checked in admin.php makes this easier.

[nacin]

After some discussion, we don't actually need any more UI here at all. Database upgrades are never intensive anymore, and if they ever would be for some major migration in the future, we can either add code back or do it in some async fashion. And they're safe.

Attached patch neuters upgrade.php and moves relevant upgrade code to admin.php. The upgrade.php file can't strictly be deleted since multisite still uses it.

At some point it would be nice to not be calling delete_site_transient() on ever multisite call, and to eventually just kill off this file.

[dd32]

Patch seems to work for me, I've only tested on a Single site instance however.

The only things which it doesn't catch, is

• Notifying the user that an upgrade took place
• Notifying the user of any errors which occurred during the upgrade

Occasionally with WP_DEBUG enabled, I'll see Database errors (ie. Index already defined) that sort of thing is going to be missed with this patch added. Whilst it's not going to be an issue for small sites, it could theoretically cause an issue for some.

I feel like using the Settings Notice API for the latter part somehow..

[nacin]

Since we normally trigger it without showing error messages, I'm not sure capturing these is worth the extra development.

[nacin]

Looks like the patch might need a tweak in the multisite branch. Just a matter of unifying it in terms of require's, etc.

[dd32]

Since we normally trigger it without showing error messages, I'm not sure capturing these is worth the extra development.

That's a fair enough point. The redirection will have to be issued before the upgrade takes place then, to ensure that output from functions doesn't cause 'headers already sent' issue.

[jane]

Punting as we're in beta 2, long past enhancment stage. Can revisit for 3.4.