Missing tabindex argument for wp_dropdown generated inputs

[Malaiac]

​http://codex.wordpress.org/Template_Tags/wp_dropdown_categories allows to create a select for categories.

There is no tabindex option in common arguments, which is a loss for usability.

There could be other functions affected.

[wojtek.szkutnik]

wp_dropdown)user affected as well

[nacin]

"which is a loss for usability" -- tabindex is generally decried as poor usability that should be used sparingly. Not to suggest that there aren't valid use cases for having the argument in wp_dropdown_*, but I'm almost -1 just because the attribute is so misused.

[wojtek.szkutnik]

Shouldn't all wp_dropdown_* functions be consistent? The current version of wp_dropdown_categories already has a tab_index argument, while my patch fixes wp_dropdown_users and wp_dropdown_pages. We should either allow tab_index everywhere or remove it from wp_dropdown_categories.

[nacin]

I don't have a problem with adding it, only I wanted to clarify that it is not a usability issue as originally stated.

Re: the patch, it doesn't look like it is properly sanitized.. The cast would only affect the comparison. Ideally it should default to false. If !== false, then absint() and use it. (0 is allowed as a tabindex value.)

[wojtek.szkutnik]

Good point - fixed it in all three functions.

[nacin]

Cool. One more thing, instead of escaping quotes: As a general rule, Use single quotes for PHP strings and double quotes for HTML attributes by default, and reverse them as appropriate to use PHP variables and such.