SQL error when editing link in Manage Links

[anonymousbugger]

Edit link form without data appears with the following is the error message above it:

Database error: [You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near at line 3]
SELECT * FROM wp_links WHERE link_id =

[JasonV]

So you clicked on an 'edit' button and got this error? I can only reproduce this if I modify the query by getting rid of 'link_id'.

[JasonV]

Found the problem. The link ID was not being passed correctly for systems without register globals turned on. Just added this line: $link_id = $_GETlink_id?;

[anonymousbugger]

$link_id = $_GETlink_id?;
is incorrrect

$link_id = $_GETlink-id?;
works if placed before line 310 in link-manager.php (note the
hyphen instead of the underscore

[JasonV]

$_GETlink-id???? I must be missing something... I can't see how that would help, the query uses "link_id".

Are you using 1.2 or a nightly?

[anonymousbugger]

Ah you know what it is? It's a bug in a plugin that rewrites WP URLs to move from underscores to hyphens. The correct URL (in the CMS) has link_id, but the plugin rewrites it to link-id.

​http://idly.org/2004/05/13/fixing-mt-urls-for-wp

[Anne]

So this bug is invalid, right?

[JasonV]

I would say so. I'm going to back out the 'fix' I made, because $link_id is set earlier in the code anyway.