Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#8004 closed defect (bug) (fixed)

comment_reply_link and cancel issues

Reported by: filosofo Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: General Keywords: comment_reply_link cancel_comment_reply_link has-patch
Focuses: Cc:



  • Not following WP template tag practice with regard to names: comment_reply_link and cancel_comment_reply_link seem parallel, but one echoes and the other returns. WP practice is to have a get_[name] to return and a [name] function to echo get_[name]'s return.
  • No filters. That means in the case of the comment_reply_link that one is stuck with inline JavaScript, which may be undesirable for a number of reasons:
    • There is no way for plugins to change the attached events.
    • There are accessibility problems.
    • Someone might not want to pollute the global JavaScript namespace.
    • It violates the principle of separating meaning, style, and behavior.

Attachments (1)

comment_reply.diff (3.2 KB) - added by filosofo 7 years ago.

Download all attachments as: .zip

Change History (2)

#1 @ryan
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.