WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#8014 closed defect (bug) (fixed)

dbDelta Breaks on backtick

Reported by: AaronCampbell Owned by:
Milestone: 2.8 Priority: high
Severity: major Version: 2.7
Component: General Keywords: has-patch tested needs-unittests
Focuses: Cc:

Description

backticks (`), which I think are best practice for MySQL, seem to kill dbDelta. It matches the table name and all the fields with the backticks still on them, then tries to match them to the database versions (`wp_mytable` != wp_mytable).

Attachments (2)

8014.001.diff (1.1 KB) - added by AaronCampbell 12 years ago.
Trims backticks from table and field names
8014.002.2.diff (920 bytes) - added by aaroncampbell 12 years ago.
Patch updated for current trunk code

Download all attachments as: .zip

Change History (7)

@AaronCampbell
12 years ago

Trims backticks from table and field names

#1 @westi
12 years ago

  • Milestone changed from 2.7 to 2.8

Not sure we should change this at this late stage in 2.7

Leave this for early 2.8

#2 @mrmist
12 years ago

  • Keywords needs-unittests added

See also #8768

#3 @Denis-de-Bernardy
12 years ago

  • Version set to 2.7

@aaroncampbell
12 years ago

Patch updated for current trunk code

#4 @aaroncampbell
12 years ago

  • Keywords tested added; needs-testing removed

#5 @ryan
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10948]) Handle backticks in dbDelta. Props AaronCampbell. fixes #8014

Note: See TracTickets for help on using tickets.