Context Navigation

← Previous Ticket
Next Ticket →

#8014 closed defect (bug) (fixed)

dbDelta Breaks on backtick

Reported by:	AaronCampbell	Owned by:
Priority:	high	Milestone:	2.8
Component:	General	Version:	2.7
Severity:	major	Keywords:	has-patch tested needs-unittests
Cc:		Focuses:

Description

backticks (`), which I think are best practice for MySQL, seem to kill dbDelta. It matches the table name and all the fields with the backticks still on them, then tries to match them to the database versions (`wp_mytable` != wp_mytable).

Attachments (2)

8014.001.diff (1.1 KB ) - added by AaronCampbell 18 years ago.: Trims backticks from table and field names
8014.002.2.diff (920 bytes ) - added by aaroncampbell 17 years ago.: Patch updated for current trunk code

Download all attachments as: .zip

Change History (7)

@AaronCampbell
18 years ago

Attachment 8014.001.diff added

Trims backticks from table and field names

#1 @westi
18 years ago

Milestone 2.7 → 2.8

Not sure we should change this at this late stage in 2.7

Leave this for early 2.8

#2 @mrmist
18 years ago

Keywords needs-unittests added

#3 @Denis-de-Bernardy
17 years ago

Version → 2.7

@aaroncampbell
17 years ago

Attachment 8014.002.2.diff added

Patch updated for current trunk code

#4 @aaroncampbell
17 years ago

Keywords tested added; needs-testing removed

#5 @ryan
17 years ago

Resolution → fixed
Status new → closed

(In [10948]) Handle backticks in dbDelta. Props AaronCampbell. fixes #8014

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#8014 closed defect (bug) (fixed)

dbDelta Breaks on backtick

Description

Attachments (2)

Change History (7)

@AaronCampbell 18 years ago

#1 @westi 18 years ago

#2 @mrmist 18 years ago

#3 @Denis-de-Bernardy 17 years ago

@aaroncampbell 17 years ago

#4 @aaroncampbell 17 years ago

#5 @ryan 17 years ago