WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8061 closed defect (bug) (fixed)

Pressing Enter in Quick Edit

Reported by: aaron_guitar Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: General Keywords:
Focuses: Cc:

Description

When you press enter in the quick edit input fields, it submits #post-filter form instead of saving the changes to the post.

Attachments (1)

8061.patch (1.2 KB) - added by aaron_guitar 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 azaozz5 years ago

  • Resolution set to invalid
  • Status changed from new to closed

"Enter" cannot be used to save the QE as it is part of the large form on the page that includes all rows. Trying to do it from JS doesn't work well in all browsers.

Closing as invalid, feel free to reopen if there's a patch that would do this reliably in all browsers.

aaron_guitar5 years ago

comment:2 aaron_guitar5 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Tested and working in Firefox 2, 3; Safari 3; IE 6, 7; Chrome.

comment:3 jacobsantos5 years ago

aaron_guitar gets the Kicks-Ass reward.

comment:4 mrmist5 years ago

Patch seems ok in Opera, too. The very first time that I tried it, it seemed that the changes I made to the post title were not reflected on the page, but I've not been able to reproduce that since.

comment:5 azaozz5 years ago

Yes, something like that was the first thing I tried too, problem is that it only works when the cursor is in an input field, so when you select something from a drop-down or enter some tags (they use textarea), this doesn't work.

comment:6 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9566]) Press Enter to save in Quick Edit, props aaron_guitar, fixes #8061

comment:7 azaozz5 years ago

Still won't save when the tags textarea is focused (user should be able to type Enter in textareas), the rest should work well.

comment:8 aaron_guitar5 years ago

The problem with the textarea is that when you press enter to select a tag from autocompletion, it will save the row. Also, if you press enter in the tags before making any edits, it triggers the autocomplete which then pops up in the upper left corner of the screen. I'll work on a solution for this.

Note: See TracTickets for help on using tickets.