WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#8111 closed defect (bug) (wontfix)

Edit Posts lists for contributors should not list drafts by other users

Reported by: mrmist Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

The edit posts lists as a contributor currently lists posts made by other users e.g. admin that are in draft state.

I don't think that these posts should appear in the list. A "preview" link is also shown that then points to the non-existent (to the contributor) article because proper security applies to actually previewing, just not the list in admin.

Attachments (2)

menu9710.diff (955 bytes) - added by mrmist 6 years ago.
menu.php alteration - fix initial view to user if they edit other posts.
template9710.diff (681 bytes) - added by mrmist 6 years ago.
change to includes\template 9710 rev to limit edit posts view

Download all attachments as: .zip

Change History (11)

comment:1 @mrmist6 years ago

Ok I've attached the hacky way of doing it - limits the edit posts screen.

What I'd liked to have done is to properly limit by author so that the post counts work, but even though the code is already there somewhere to list by author I can't figure out how it works.

@mrmist6 years ago

menu.php alteration - fix initial view to user if they edit other posts.

@mrmist6 years ago

change to includes\template 9710 rev to limit edit posts view

comment:2 @mrmist6 years ago

It looks like to fix the actual post counts list at the top it would need a seperate function similar to wp_count_posts that just counts the posts for a specific user, or counts based on editability rather than viewability.

comment:3 @ryan6 years ago

  • Milestone changed from 2.7 to 2.8

Let's see if we can get the query sorted for 2.8.

comment:4 @Denis-de-Bernardy6 years ago

alternatively, it could be desirable, in the sense that contributors might be working as a team and need to know what posts others are working on.

comment:5 @Denis-de-Bernardy6 years ago

  • Component changed from General to Administration
  • Keywords needs-patch added

comment:6 @janeforshort6 years ago

  • Milestone changed from 2.8 to 2.9

Punting to 2.9 due to feature freeze.

comment:7 @sg111116 years ago

If they want to work as a team, you can give them author roles or higher. I don't think the contributors should be able to see these titles of the pending posts and comments.

comment:8 @azaozz5 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

This was changed to only show the titles of other users' drafts. Feel free to reopen if there's a consensus we should hide that too.

comment:9 @lloydbudd5 years ago

  • Milestone 2.9 deleted
Note: See TracTickets for help on using tickets.