Auto update plugin breaks plugins

[ranok]

I was updating my plugins using the auto update system on Wordpress 2.6.3 and after upgrading Akismet to the latest version, the plugins page spit out some errors at the top of the page saying:
Warning: include_once(/home/public/wp-content/plugins/akismet) Fatal error: 0 on wp-settings line 425
...
I did the same for the WP-Super-Cache to make sure it wasn't just a messed up akismet plugin, but I got the same results. Curious I looked at the code and found
if ( != $plugin && 0 == validate_file($plugin) && file_exists(WP_PLUGIN_DIR . '/' . $plugin) )

include_once(WP_PLUGIN_DIR . '/' . $plugin);

However, the $plugin var here is a directory, which PHP doesn't like one bit. I have attached a diff to fix this, and now it works just dandy.

[ranok]

A diff of what I did to fx the auto update plugin feature

[DD32]

That fixes the warning, But doesnt fix the root cause of why its not returning the full path to the plugin, something else broke elsewhere to cause that, But i cannot reproduce it under 2.6 or 2.7

This shouldnt be a problem under 2.7 AFAIK, But changing the file_exists() to is_file() seems like a good idea eitherway.

[ranok]

It does fix the warning, and also makes the plugin work again. I have found this bug in 2.7 as well, and had to fix line 485.

[ranok]

A fix for version 2.7.

[Denis-de-Bernardy]

+1 to the wps.diff patch, though.

[Denis-de-Bernardy]

mm, nevermind that. this can't happen in 2.8 anyway (or then the folder is called something.php)

steps to reproduce the other issue would be useful.

[Denis-de-Bernardy]

closing as invalid until then.