WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#8142 closed defect (bug) (fixed)

misc i18n fixes for 2.7

Reported by: nbachiyski Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

  • Admin paging: __( 'Displaying %s&#8211;%s of %s' ) . '</span>' . __( '%s' )

The last %s doesn't have to be i18n-ed.

  • Delete confirmations:
    var n = $('#the-list input[type="checkbox"]:checked').length;
    var m = n > 1 ? '<plural message>' : 'singular message';
    

Pluralization by hand is a bad idea. Plural only confirmations sound well enough in English.

  • via -> via %s

Attachments (4)

i18n-2.7.diff (11.2 KB) - added by nbachiyski 7 years ago.
i18n-2.7-2.diff (2.7 KB) - added by nbachiyski 7 years ago.
Some more js plurals and one forgotten regular plural
i18n-2.7-3-medium-differentiate.diff (571 bytes) - added by nbachiyski 7 years ago.
Differentiate between Medium occurences
i18n-2.7-4-search-form-label.diff (637 bytes) - added by nbachiyski 7 years ago.
Search form label isn't i18n-ed in get_search_form()

Download all attachments as: .zip

Change History (15)

@nbachiyski7 years ago

comment:1 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9589]) i18n fixes from nbachiyski. fixes #8142

comment:2 @nbachiyski7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@nbachiyski7 years ago

Some more js plurals and one forgotten regular plural

comment:3 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9668]) i18n plurals fixes from nbachiyski. fixes #8142

comment:4 @nbachiyski7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@nbachiyski7 years ago

Differentiate between Medium occurences

comment:5 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9789]) Add gettext context. Props nbachiyski. fixes #8142

comment:6 @Dutchguys7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Last change breaks google gears for me in WordPress 2.7-beta3-9791

comment:7 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9794]) Stub _c() for gears manifest. fixes #8142

@nbachiyski7 years ago

Search form label isn't i18n-ed in get_search_form()

comment:8 @nbachiyski7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9813]) Escape gettext in attribute. Props nbachiyski. fixes #8142

comment:10 @tai7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Two more please!

in /wp-includes/comment-template.php around the line 1184:

<div class="comment-meta commentmetadata"><a href="<?php echo htmlspecialchars( 
get_comment_link( $comment->comment_ID ) ) ?>"><?php printf(__('%1$s at %2$s'), 
get_comment_date('F jS, Y'),  get_comment_time()) ?></a><?php 
edit_comment_link('edit','&nbsp;&nbsp;','') ?></div>
get_comment_date('F jS, Y')

->

get_comment_date()

and

edit_comment_link('edit','&nbsp;&nbsp;','')

->

edit_comment_link(__('Edit'),'&nbsp;&nbsp;','')

comment:11 @azaozz7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9854]) I18n: fix get_comment_date and edit_comment_link in comment-template.php, props tai. Add class to "Says:", fixes #8142

Note: See TracTickets for help on using tickets.