Automatic upgrade runs out of memory

[DD32]

It appears that for some people, 32MB of PHP memory_limit just isnt enough for the PclZip class to do its work

It might be an idea to set the memory limit in the unzip function to something higher (Like happens in the Thumbnail creation -- Since GD can use obscene ammounts of memory sometimes, it attempts to set it to 256MB memory_limit) to prevent these errors occuring half way through the upgrade decompression

[ryan]

Sounds good.

[westi]

+1

i doubt it's actually the unzipping that has swallowed all 32M but other stuff has just got us too close to the limit.

[DD32]

Yeah, most of the 32M is used up by the rest of WP, But loading 7MB worth of strings in PHP definately takes its toll, along with the temporary variables & all that which is used internally by the class pushes it over the edge.

ryan: that patch is basically what i was thinking of myself, Wasnt sure 256 was needed, but setting it too high couldnt cause issues could it?

[ryan]

(In [9612]) Increase memory limit when unzipping. fixes #8149

[ryan]

I chose 256 since that is what we're using in image.php and it seems to be working okay.