WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8151 closed defect (bug) (fixed)

Typo in wp-admin/includes/plugin-install.php

Reported by: Speedboxer Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

There's a typo in wp-admin/includes/plugin-install.php in the incompatible version check. It says:

This plugin has not been marked as being not compatible with your version of WordPress.

It's a double negative.

Attachments (1)

8151.diff (1.0 KB) - added by Speedboxer 6 years ago.
Reword incompatible line

Download all attachments as: .zip

Change History (6)

@Speedboxer6 years ago

Reword incompatible line

comment:1 @Speedboxer6 years ago

  • Keywords has-patch added

comment:2 @Viper007Bond6 years ago

Looks good to me.

comment:3 follow-up: @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [9619]. Looks good but why change the meaning? Plugin is not set as incompatible, it's "not marked as" compatible.

comment:4 in reply to: ↑ 3 @Speedboxer6 years ago

Replying to azaozz:

Fixed in [9619]. Looks good but why change the meaning? Plugin is not set as incompatible, it's "not marked as" compatible.

Well, they're the same thing. Because when you set the version required, you're automatically setting older versions as incompatible. So either way you word it, it's the same in the end.

I just think

This plugin has been marked as being incompatible with your current version of WordPress.

sounds/reads better than

This plugin has not been marked as compatible with your version of WordPress.

comment:5 @DD326 years ago

i agree with the 'incompatible' wording for the lower bound (which this is dealing with), While it might be common for plugins to work on older installs, if the requirement field has been set, its likely that the plugin uses functionality introduced in that version.

for the upper bound, 'not been tested with your current version' leaves it much more open, and says "try me!"

Note: See TracTickets for help on using tickets.