#8151 closed defect (bug) (fixed)
Typo in wp-admin/includes/plugin-install.php
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 2.7 | Priority: | normal |
| Severity: | normal | Version: | 2.7 |
| Component: | Administration | Keywords: | has-patch |
| Focuses: | Cc: |
Description
There's a typo in wp-admin/includes/plugin-install.php in the incompatible version check. It says:
This plugin has not been marked as being not compatible with your version of WordPress.
It's a double negative.
Attachments (1)
Change History (6)
#3
follow-up:
↓ 4
@
15 years ago
- Resolution set to fixed
- Status changed from new to closed
Fixed in [9619]. Looks good but why change the meaning? Plugin is not set as incompatible, it's "not marked as" compatible.
#4
in reply to:
↑ 3
@
15 years ago
Replying to azaozz:
Fixed in [9619]. Looks good but why change the meaning? Plugin is not set as incompatible, it's "not marked as" compatible.
Well, they're the same thing. Because when you set the version required, you're automatically setting older versions as incompatible. So either way you word it, it's the same in the end.
I just think
This plugin has been marked as being incompatible with your current version of WordPress.
sounds/reads better than
This plugin has not been marked as compatible with your version of WordPress.
#5
@
15 years ago
i agree with the 'incompatible' wording for the lower bound (which this is dealing with), While it might be common for plugins to work on older installs, if the requirement field has been set, its likely that the plugin uses functionality introduced in that version.
for the upper bound, 'not been tested with your current version' leaves it much more open, and says "try me!"
Reword incompatible line