Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#8165 closed defect (bug) (invalid)

Add error checking to Add-Tag form

Reported by: DD32 Owned by:
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: UI Keywords:
Focuses: Cc:


Note: May require patch from #6593, But i dont think its required

Attached patch adds error messages for attempting to add a Tag that exists (either the Tag name exists in the Tag taxonomy, Or the specified tag slug is in use by a term (in any taxonomy)).

Patch only affects Ajax-adds.

Attachments (1)

8165.diff (1.0 KB) - added by DD32 6 years ago.

Download all attachments as: .zip

Change History (8)

@DD326 years ago

comment:1 @ryan6 years ago

  • Milestone changed from 2.7 to 2.8

Nice but not critical for 2.7. Postponing.

comment:3 @ryan6 years ago

wp_insert_term() can rewrite slugs in some instances, so we can't bail on existing slugs before calling it.

comment:4 @Denis-de-Bernardy6 years ago

rather than raise an error, why not process it? as in, update the tag...

comment:5 @Denis-de-Bernardy6 years ago

  • Keywords needs-patch added; has-patch removed

patch is broken...

comment:6 @Denis-de-Bernardy6 years ago

itching to close this as invalid. I tested another ticket today, that basically went:

if a post contains foo as tag, and you add "foo, bar", then it fails.

but it worked in trunk... is the patch still current, or can we safely close as fixed?

comment:7 @hakre6 years ago

  • Keywords needs-patch removed
  • Resolution set to invalid
  • Status changed from new to closed

Ajax adding does supercool work w/o any messages. The new UI is supercool with that. You actually see your tags and you have autocomplete so you have already seen that the tag is not new. Sometimes less is more. Closed as invalid because it isn't a deficy any longer.

If someone really has problems with the 2.8 trunk UI variant, feel free to reopen.

Note: See TracTickets for help on using tickets.