WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#8182 closed defect (bug) (fixed)

Custom Fields / Post Meta JS seems broken

Reported by: mdawaffe Owned by: mdawaffe
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: UI Keywords: has-patch
Focuses: Cc:

Description

The hide/show behavior is inconsistent with the rest of the interface.

Attached:

Add New inputs are hidden by default, slide open when clicked.

CSS tweaks.

Attachments (3)

8182.diff (5.7 KB) - added by mdawaffe 7 years ago.
Post Meta Box.png (24.5 KB) - added by mdawaffe 7 years ago.
8182-2.patch (1.4 KB) - added by azaozz 7 years ago.
Show only text input field for new blogs with empty post meta table

Download all attachments as: .zip

Change History (11)

@mdawaffe7 years ago

comment:1 @mdawaffe7 years ago

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

comment:2 @ryan7 years ago

"Enter new/Cancel" for showing either the dropdown or the input was nice. Can that be retained?

comment:3 @ryan7 years ago

  • Component changed from General to UI

comment:4 @azaozz7 years ago

Think this makes it to look more consistent, but the functionality is more inconsistent. The user has to open the postbox (if closed), then click again to open the "add" form.

This is different than adding categories as they can be selected by a checkbox. When adding meta fields, both Name and Value have to be entered, so the form is used every time.

Also the main usability complain was that both "select existing" and "add new" were visible at the same time. A lot of users were unclear what to do.

@mdawaffe7 years ago

comment:5 @mdawaffe7 years ago

  • Keywords commit removed

http://trac.wordpress.org/attachment/ticket/8182/Post%20Meta%20Box.png

I don't have any post meta in a fresh install. That's what I see, which is totally confusing. "Enter New" is what I'm trying to do: enter a new post meta.

If we don't apply the patch above, we need to show the text field (without the cancel link) if there's no select dropdown.

Regardless of whether we apply the patch above, we should consider getting rid of the JS fanciness and just adding some text between the select dropdown and the text field:

"-- OR --", "Select a meta name above or add a new one below", ...

comment:6 @azaozz7 years ago

The main usability concern is that both the select and type new Meta Name fields are available at the same time. Seems that this confuses a lot of users.

The same scenario exists on the first tab in the uploader, where both "From your computer" and "From Internet" are shown at the same time. Seems that many users don't like that/get confused, so we will have to separate them there in two different tabs.

Adding an explanation that only one "Meta Name" field should be used would improve the usability (and I personally prefer not to use js there too) but unless we really make only one field available, it seems this will remain confusing for many.

@azaozz7 years ago

Show only text input field for new blogs with empty post meta table

comment:7 @azaozz7 years ago

(In [9992]) Hide post meta select when meta table is empty, see #8182

comment:8 @markjaquith7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.