Check all checkbox never becomes checked

[jick]

I can't recall if it worked in previous versions of WordPress but in the current svn version of 2.7 when you view the edit comments, edit posts, or edit pages areas and check the box in the table header that checks all the other boxes in the table, the check box you just checked never becomes checked. It's always unchecked. The check all function still works. You can check the check all box and all the checkboxes in the table will be checked and when you click it again the checkboxes in the table will become unchecked but, the check all check box itself is never checked. I think that is incorrect. I'm not sure how the check all function works but I do know it is Javascript.

After some looking around it seems that the function in question currently resides in ./wp-admin/js/common.js.

One other thing I want to note is that in 2.7 we now have the check all checkbox in the header and the footer of the tables. So, not only does the check all checkbox at the top of the table need to be fixed but also the one at the bottom of the table. The one at the bottom should become checked when you check the top one and vice-versa.

Not sure how much retooling of the check all function will be required for this but I do think it is needed.

[DD32]

The checkall function actually inverts the list, It doesnt actually check them all.

IMO, It shouldn't check table rows, and instead should set them to non-checked on click (Much the same as happens now, Except for the bottom checkbox)

[jick]

Replying to DD32:

The checkall function actually inverts the list, It doesnt actually check them all.

IMO, It shouldn't check table rows, and instead should set them to non-checked on click (Much the same as happens now, Except for the bottom checkbox)

Umm... I'm not sure I understand what you mean. Perhaps it's just the late hour right now but, could you maybe explain that a bit more? Thanks.

[DD32]

Check one or 2 of the checkboxes beside a post/page/comment, Now click the checkbox at the top or bottom, Those you had selected, will now be unselected, and those which werent selected, will now be selected.

[azaozz]

(In [9708]) Improve the check all: click to check all checkboxes, click again to uncheck all, Shift/click to toggle. Shift/clicking two consecutive boxes checks the range between them as before. Fixes #8217

[jick]

Everything works good for me now. Thanks for the fix.