WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#8220 closed defect (bug) (fixed)

Unused variables/variable typo's cleanup

Reported by: DD32 Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: General Keywords: has-patch
Focuses: Cc:

Description

Patch removed variables which are not used by any function, and corrects a number of typo's

There is also an undefined variable which i have not touched:
register_taxonomy() refers to an undefined variable $term; It looks like it should be the slug to me, but i'm not entirely sure of it, So i've left it unchanged:
http://trac.wordpress.org/browser/trunk/wp-includes/taxonomy.php#L185

Attachments (1)

unused.diff (15.0 KB) - added by DD32 7 years ago.

Download all attachments as: .zip

Change History (4)

@DD327 years ago

comment:1 @DD327 years ago

Few more notes:

  • wp-includes/pluggable.php: get_avatar(); $defaults[$avatar_default][1] doesnt exist, As far as i could tell, 'custom' shouldnt be passed to that function, instead, a URL should be, So i've assumed that branch was supposed to add the size arg to the url..
  • Most of those changes are untested, In the sense that the script I refer to for checking didnt come up with any other uses of the variables, And i couldnt locate anything which was refering to them.

comment:2 @ryan7 years ago

(In [9716]) Unused var fixes. Props DD32. see #8220

comment:3 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.