Set content-length for HTTP API when the developer doesn't manually set it.

[jacobsantos]

There might be some instances when the developer does not set the content-length and servers might not work directly. There is also a known instance where mod_security will reject HTTP POST requests that don't have the header set.

The patch sets the value if the developer doesn't already set it.

[jacobsantos]

patch based off of r9729.

[DD32]

IMO, the Developer shouldnt be setting the content length at all, That should be taken care of by the Class.

Eg: ​http://trac.wordpress.org/browser/trunk/wp-includes/update.php#L214[[Br]]
I'd personally prefer it to be written as:

214	    $options = array(
215	        'method'        => 'POST',
216	        'timeout'        => 3,
217	        'body'            => array('themes' => serialize( $themes ) ),
	        'headers'	 => array();
218	    );

225	    $raw_response = wp_remote_request( 'http://api.wordpress.org/themes/update-check/1.0/', $options );

Oh, And wouldnt it be better to pull the lines above that patch ​http://trac.wordpress.org/browser/trunk/wp-includes/http.php#L249 (Lines 249, 250) out of that block and set them for any requests which need it, rather than duplicating the line?

[jacobsantos]

DD32,

You are correct. All code should be as you said, but should be made in a new ticket.

[ryan]

(In [9741]) Auto set content-length. Props jacobsantos. fixes #8249