WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#8255 closed defect (bug) (fixed)

WPCOMism in xmllrpc.php

Reported by: donncha's profile donncha Owned by: josephscott's profile josephscott
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: XML-RPC Keywords:
Focuses: Cc:

Description

The check for site_id on line 432 of xmlrpc.php is a piece of legacy code from WordPress.com and has been taken out in WordPress MU.

That foreach() loop is also missing a restore_current_blog() call, the complement of switch_to_blog(). It should be added immediately after the definition of $is_admin.

Attachments (1)

xmlrpc.php.diff​ (573 bytes) - added by josephscott 17 years ago.

Download all attachments as: .zip

Change History (7)

#1 @ryan
17 years ago

Those functions don't exist in WP.

#2 @ryan
17 years ago

  • Component changed from General to XML-RPC
  • Owner changed from anonymous to josephscott

@josephscott
17 years ago

#3 @josephscott
17 years ago

Here's an untested patch based on a brief discussion with Donncha.

#4 @ryan
17 years ago

get_blogs_of_user() doesn't exist for WP. Nor do the switch and restore functions.

#5 @ryan
17 years ago

Ah, I see. We test for is_site_admin() to short-circuit for WP. The fix is so WPMU picks it up on merge.

#6 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9798]) wp_getUsersBlogs() fix from josephscott. fixes #8255

Note: See TracTickets for help on using tickets.