#8268 closed enhancement (wontfix)
Apply image_downsize filter before wp_attachment_is_image check in image_downsize function
Reported by: | jbrinley | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.7 |
Component: | Gallery | Keywords: | has-patch |
Focuses: | Cc: |
Description
The function image_downsize
in wp-include/media.php calls wp_attachment_is_image
, which must return true
before applying the image_downsize
filter. By moving the call to the image_downsize
filter to the beginning of the function, plugins (let's say, for example, the Custom Thumbnails plugin) can return representations of non-image media.
The only possible negative consequence that I can see: plugin writers can't assume that the image_downsize
filter will only be called for images (but I don't know that they should assume that, anyway).
Attachments (1)
Change History (7)
Note: See
TracTickets for help on using
tickets.
Patch for image_downsize in wp-includes/media.php