WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 16 years ago

Last modified 16 years ago

#8292 closed defect (bug) (duplicate)

Threaded comment information in atom feed

Reported by: dtsn's profile dtsn Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Feeds Keywords:
Focuses: Cc:

Description

WordPress 2.7 will support threaded commenting, but currently none of this information is exposed through the atom feed, so it would just show as a flat list. This would make the comments hard to follow in external readers.

I've created a patch to output threading information in the atom feed, as specified by RFC 4685 (​http://www.ietf.org/rfc/rfc4685.txt).

Attachments (2)

atom-threaded-comments.patch​ (1.2 KB) - added by dtsn 17 years ago.
Patch to add threading information to atom comment feed
add_xmlns.patch​ (1.4 KB) - added by alexforrow 16 years ago.
Patch to add xml namespace information

Download all attachments as: .zip

Change History (8)

@dtsn
17 years ago

Patch to add threading information to atom comment feed

#1 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9818]) Add threaded comment info to atom feed. Props dtsn. fixes #8292

#2 @oddthinking
16 years ago

  • Component changed from Comments to Feeds
  • Resolution fixed deleted
  • Status changed from closed to reopened

Atom comment feeds no longer validate after this change.

The problem appears to be in lines 76 and 81 of feed-atom-comments.php.

They have illegal "rel" attributes on an in-reply-to tag.

RFC4685 defines a "ref" attribute, which I believe is what was intended. In these lines, please change "rel" to "ref".

(Sorry for leaving the actual task to some more experienced WordPress developers.)

#3 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10164]) ref not rel. Props oddthinking. fixes #8292

@alexforrow
16 years ago

Patch to add xml namespace information

#4 @alexforrow
16 years ago

  • Milestone changed from 2.7 to 2.7.1
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to defect (bug)

Validation is failing on certain XML implementations.

This is because we are not including information about the XML namespace for this extension. A 'xmlns' attribute inside the 'in-reply-to' tag is required. The change required is tiny, see add_xmlns.patch.

#5 @alexforrow
16 years ago

  • Resolution set to duplicate
  • Status changed from reopened to closed

Already been fixed in #8626

#6 @mrmist
16 years ago

  • Milestone 2.7.1 deleted
Note: See TracTickets for help on using tickets.