WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8294 closed defect (bug) (fixed)

Improperly formatted divs in admin-footer.php

Reported by: sivel Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: UI Keywords:
Focuses: Cc:

Description

In admin header their are two extra divs following favorite_actions()

<?php favorite_actions(); ?>
</div>
</div>

This is prematurely closing the wpwrap and wpcontent divs.

However simply removing these divs causes some css issues. The left menu bar moves to the right slightly and the footer moves upwards leaving a blank space below.

Attachments (1)

admin-footer.diff (702 bytes) - added by sivel 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 ryan5 years ago

  • Component changed from General to UI
  • Owner anonymous deleted

comment:2 ryan5 years ago

Aren't those divs closing wp-head and wphead-info? My IDE matches them to those divs, anyway.

comment:3 azaozz5 years ago

  • Milestone 2.7 deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version 2.7 deleted

Ryan is right, all DIVs are closed properly in the header.

comment:4 sivel5 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Okay...there are definitely 2 extra closing divs coming from somewhere. Guess I mis read the output originally.

Validation errors:

Result: 4 errors / 0 warnings


line 226 column 77 - Error: there is no attribute "autocomplete"
line 312 column 76 - Error: document type does not allow element "br" here
line 406 column 32 - Error: end tag for element "div" which is not open
line 407 column 5 - Error: end tag for element "div" which is not open

comment:5 sivel5 years ago

  • Summary changed from Extra divs in admin-header.php to Improperly formatted divs in admin-footer.php

Ok...I was wrong about there being 2 extra closing divs all together. The problem was improperly formatted opening divs in admin-footer.php.

I will attach a patch shortly.

sivel5 years ago

comment:6 westi5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [9832]) Format the clear DIVs properly. Fixes #8294 props sivel.

comment:7 westi5 years ago

  • Milestone set to 2.7
  • Version set to 2.7
Note: See TracTickets for help on using tickets.