WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#8323 closed defect (bug) (duplicate)

em-dash Should be en-dash in wptexturize()

Reported by: misieg772 Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.7
Component: Formatting Keywords: needs-patch
Focuses: Cc:

Description

there is a bug in wptexturize - when i type two hyphens into post box:

--

above is converted to em-dash (—) which is wrong. it should be converted to en-dash (–)

regards, grzegorz

Attachments (2)

formatting.php (68.6 KB) - added by jamierumbelow 6 years ago.
8323.diff (988 bytes) - added by jacobsantos 6 years ago.
diff of above file.

Download all attachments as: .zip

Change History (18)

@jamierumbelow6 years ago

comment:1 @jamierumbelow6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed!

comment:2 @jacobsantos6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Tickets are only fixed if the issue was committed.

comment:3 @jacobsantos6 years ago

  • Keywords has-patch needs-testing added; wptexturize removed

comment:4 @jacobsantos6 years ago

  • Keywords has-patch removed

@jacobsantos6 years ago

diff of above file.

comment:5 @jacobsantos6 years ago

  • Keywords has-patch dev-feedback added; needs-testing removed

Add diff of attached file.

comment:6 @jacobsantos6 years ago

  • Summary changed from en-dash wanished in wptexturize? to en-dash vanished in wptexturize?

comment:7 @jacobsantos6 years ago

  • Summary changed from en-dash vanished in wptexturize? to Change em-dash to en-dash in wptexturize()

comment:8 @jacobsantos6 years ago

  • Summary changed from Change em-dash to en-dash in wptexturize() to em-dash Should be en-dash in wptexturize()

comment:9 follow-up: @markjaquith6 years ago

  • Milestone changed from 2.7 to 2.8

Can someone provide a link to a style resource that confirms that this change is correct?

comment:10 in reply to: ↑ 9 @joshuagoodwin6 years ago

Replying to markjaquith:

Can someone provide a link to a style resource that confirms that this change is correct?

The spaced em-dash is regarded as okay by some, however the en-dash should be a option. See http://trac.wordpress.org/ticket/8161

comment:11 @ryan6 years ago

  • Component changed from General to Formatting

comment:12 @Denis-de-Bernardy6 years ago

  • Keywords needs-patch added; has-patch dev-feedback removed
  • Milestone changed from 2.8 to Future Release

broken patch

comment:13 @Denis-de-Bernardy6 years ago

  • Milestone changed from Future Release to 2.9

comment:14 @azaozz5 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

Agree with markjaquith. If the en dash is needed as an option, that should be handled by a plugin.

comment:15 @Denis-de-Bernardy5 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:16 @Denis-de-Bernardy5 years ago

  • Milestone 2.9 deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

#8161 / r10973 (fixed)

Note: See TracTickets for help on using tickets.