WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#8350 closed defect (bug) (fixed)

_pad_term_counts not availabe to custom hierarchical taxonomies

Reported by: mgsisk Owned by: ryan
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Taxonomy Keywords: has-patch tested commit
Focuses: Cc:
PR Number:

Description

It seems like _pad_term_counts might be useful for custom hierarchical taxonomies. Instead of checking for the category taxonomy, as the function does now:

// This function only works for post categories.
	if ( 'category' != $taxonomy )
		return;

it seems it'd be more useful to check if the taxonomy is hiearchical:

// This function only works for hierarchical taxonomies.
	if ( !is_taxonomy_hierarchical( $taxonomy ) )
		return;

Attachments (1)

8350.diff (422 bytes) - added by Denis-de-Bernardy 10 years ago.

Download all attachments as: .zip

Change History (6)

#1 @Denis-de-Bernardy
11 years ago

  • Component changed from General to Taxonomy
  • Keywords needs-patch added; taxonomy pad_count custom pad_term_counts removed
  • Milestone set to 2.8
  • Owner changed from anonymous to ryan
  • Version set to 2.7

#2 @Denis-de-Bernardy
10 years ago

  • Milestone changed from 2.8 to Future Release

#3 @Denis-de-Bernardy
10 years ago

  • Keywords has-patch tested commit added; needs-patch removed
  • Milestone changed from Future Release to 2.8

#5 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.