WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#8383 closed enhancement (fixed)

Remove code class from input fields

Reported by: ydekproductions Owned by:
Milestone: 2.8 Priority: low
Severity: trivial Version: 2.7
Component: UI Keywords: has-patch
Focuses: Cc:

Description

In the options page, a few of the <input> boxes have the class "code" applied to them causing the font to render with Consolas instead of Lucide. I don't think this is intentional because it looks kinda weird to me and it's not consistent for all text fields.

Attachments (4)

remove-code-class.diff (6.4 KB) - added by ydekproductions 7 years ago.
8383.patch (3.1 KB) - added by johnbillion 6 years ago.
Refreshed patch for 2.8
8383-2.patch (4.2 KB) - added by johnbillion 6 years ago.
Some more code classes
8383-3.patch (804 bytes) - added by johnbillion 6 years ago.
And another one.

Download all attachments as: .zip

Change History (14)

comment:1 @kpdesign7 years ago

  • Keywords has-patch added

This change still needs to be committed to ensure consistency with fonts in form fields.

comment:2 @azaozz7 years ago

  • Milestone 2.7 deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version 2.7 deleted

Think this is intentional to render URLs with fixed width font.

comment:3 @ydekproductions7 years ago

  • Milestone set to 2.7
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version set to 2.7

Even if that's the case, not all fields with the code class are places to enter in a url. And not all fields where you enter in a url have the code class.

So there's a lot of inconsistencies.

comment:4 @markjaquith7 years ago

  • Milestone changed from 2.7 to 2.8

Let's get a patch to make it consistent for 2.8

@johnbillion6 years ago

Refreshed patch for 2.8

comment:5 @johnbillion6 years ago

  • Component changed from General to UI
  • Priority changed from normal to low
  • Severity changed from normal to trivial
  • Type changed from defect (bug) to enhancement

Refreshed patch for 2.8.

The 'code' class is now exclusive to URL fields, with the exception of the 'Comment Moderation' and 'Comment Blacklist' textareas as the monospace font helps legibility on these fields.

comment:6 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10971]) Remove code class from some input fields, add to URL input fields, props johnbillion, fixes #8383

comment:7 @johnbillion6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Missed a couple.

@johnbillion6 years ago

Some more code classes

@johnbillion6 years ago

And another one.

comment:9 @johnbillion6 years ago

And another one.

comment:10 @azaozz6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10995]) Add "code" class to more URL input fields, props johnbillion, fixes #8383

Note: See TracTickets for help on using tickets.