Make WordPress Core

Opened 18 years ago

Closed 17 years ago

#8383 closed enhancement (fixed)

Remove code class from input fields

Reported by: ydekproductions Owned by:
Priority: low Milestone: 2.8
Component: UI Version: 2.7
Severity: trivial Keywords: has-patch
Cc: Focuses:

Description

In the options page, a few of the <input> boxes have the class "code" applied to them causing the font to render with Consolas instead of Lucide. I don't think this is intentional because it looks kinda weird to me and it's not consistent for all text fields.

Attachments (4)

remove-code-class.diff (6.4 KB ) - added by ydekproductions 18 years ago.
8383.patch (3.1 KB ) - added by johnbillion 17 years ago.
Refreshed patch for 2.8
8383-2.patch (4.2 KB ) - added by johnbillion 17 years ago.
Some more code classes
8383-3.patch (804 bytes ) - added by johnbillion 17 years ago.
And another one.

Download all attachments as: .zip

Change History (14)

#1 @kpdesign
18 years ago

  • Keywords has-patch added

This change still needs to be committed to ensure consistency with fonts in form fields.

#2 @azaozz
18 years ago

  • Milestone 2.7
  • Resolutionwontfix
  • Status newclosed
  • Version 2.7

Think this is intentional to render URLs with fixed width font.

#3 @ydekproductions
18 years ago

  • Milestone2.7
  • Resolution wontfix
  • Status closedreopened
  • Version2.7

Even if that's the case, not all fields with the code class are places to enter in a url. And not all fields where you enter in a url have the code class.

So there's a lot of inconsistencies.

#4 @markjaquith
18 years ago

  • Milestone 2.72.8

Let's get a patch to make it consistent for 2.8

@johnbillion
17 years ago

Refreshed patch for 2.8

#5 @johnbillion
17 years ago

  • Component GeneralUI
  • Priority normallow
  • Severity normaltrivial
  • Type defect (bug)enhancement

Refreshed patch for 2.8.

The 'code' class is now exclusive to URL fields, with the exception of the 'Comment Moderation' and 'Comment Blacklist' textareas as the monospace font helps legibility on these fields.

#6 @azaozz
17 years ago

  • Resolutionfixed
  • Status reopenedclosed

(In [10971]) Remove code class from some input fields, add to URL input fields, props johnbillion, fixes #8383

#7 @johnbillion
17 years ago

  • Resolution fixed
  • Status closedreopened

Missed a couple.

@johnbillion
17 years ago

Some more code classes

@johnbillion
17 years ago

And another one.

#9 @johnbillion
17 years ago

And another one.

#10 @azaozz
17 years ago

  • Resolutionfixed
  • Status reopenedclosed

(In [10995]) Add "code" class to more URL input fields, props johnbillion, fixes #8383

Note: See TracTickets for help on using tickets.