WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 8 years ago

#8461 closed defect (bug) (fixed)

MediaUpload: "Select Files" Flash button doesn't resize for translation

Reported by: xibe Owned by:
Milestone: 3.3 Priority: normal
Severity: normal Version: 2.7
Component: Upload Keywords: i18n needs-patch
Focuses: Cc:

Description

The "Select Files" button from the /wp-admin/media-new.php screen is not resized for translation that are longer.

For instance, in French the translation is "Sélectionner des fichiers", and the button's size makes that we can only read "Sélectionner des fich".

Since it'd be hard to make a Flash app resize depending of its content (I guess), I'd advise to use a single word for this button, such as "Browse..."

Attachments (1)

wp27rc1-flashupload-fr.png (12.9 KB) - added by xibe 11 years ago.
Screenshot in French.

Download all attachments as: .zip

Change History (6)

@xibe
11 years ago

Screenshot in French.

#1 @azaozz
11 years ago

  • Milestone 2.7 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Unfortunately this button is part of the flash uploader and is fixed width. When translating, perhaps "Select files" can be substituted with something shorter like "Upload" (as in 2.6), "Select", "Choose", etc.

#2 @hakre
9 years ago

  • Milestone set to Future Release
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Isn't this button parametrized?

And even if not, shouldn't this be upstream to the project we're incorporating here? I mean at least we should provide the feedback because WP is profiting a lot from this uploader as far as I can say.

So I'll reopen and put this on future release.

#3 @hakre
9 years ago

related: #13475

#4 @hakre
9 years ago

Just checked the code, my assumption was right that this is set by parameters and it's not hard-coded in the swf.

Here is the according HTML code taken out of the current version's output for the flash upload:

<object id="SWFUpload_0" type="application/x-shockwave-flash" data="/wp-includes/js/swfupload/swfupload.swf?preventswfcaching=1274426323139" width="132" height="23" class="swfupload">
  <param name="wmode" value="window">  
  <param name="movie" value="/wp-includes/js/swfupload/swfupload.swf?preventswfcaching=1274426323139">  
  <param name="quality" value="high">
  <param name="menu" value="false">
  <param name="allowScriptAccess" value="always">
  <param name="flashvars" value="//Flashvars//">
</object>

Flashvars are the following (decoded):

SWFUpload_0
uploadURL=http://.../wp-admin/async-upload.php
useQueryString=false
requeueOnError=false
httpSuccess=
assumeSuccessTimeout=0
params=post_id=1243
auth_cookie=xxxxx%7C1275122458%7C835901edd192d0fb64d5e0cf3df1c2fb
logged_in_cookie=xxxxx%7C1275122458%7C9ddb9cfe5dd5c7c23846b50237577b45
&amp;
_wpnonce=f4f9391e98
type=image
tab=type
short=1
filePostName=async-upload
fileTypes=*.jpg;*.jpeg;*.png;*.gif;*.pdf;*.doc;*.ppt;*.odt;*.pptx;*.docx
fileTypesDescription=All Files
fileSizeLimit=1536000000b
fileUploadLimit=0
fileQueueLimit=0
debugEnabled=false
buttonImageURL=http://..../wp-includes/images/upload.png
buttonWidth=132
buttonHeight=23
buttonText=<span class="button">Select Files</span>
buttonTextTopPadding=3
buttonTextLeftPadding=0
buttonTextStyle=.button { text-align: center; font-weight: bold; font-family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif; font-size: 11px; text-shadow: 0 1px 0 #FFFFFF; color:#464646; }
buttonAction=-110
buttonDisabled=false
buttonCursor=-1

To solve this problem, an idea would be to offer sizes (this 132 width and maybe something bigger like 198 that offers more space - isn't there this 1.5 rule in translation?).

RTL considerations might apply as well, but I only write it here, that has not been raised in this ticket. I do not know if flash supports RTL text.

At least the problem with size should be easy to solve.

#5 @ocean90
8 years ago

  • Milestone changed from Future Release to 3.3
  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed through the new file uploader (#18206), see http://cl.ly/2V2i2A2I3B1g3H321q1b.

Note: See TracTickets for help on using tickets.