WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8462 closed enhancement (fixed)

Enhanced "autocomplete=off" enforcement for password field in user edit

Reported by: Ozh Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version: 2.7
Component: Optimization Keywords: has-patch password user-edit reporter-feedback
Focuses: Cc:

Description

Even with autocomplete=off, the first password field of the user edit form can be pre-populated with current password

Simply adding $('#pass1').val('') makes sure it's really "autocomplete=off"

Attachments (2)

pwd-prepopulated.gif (18.6 KB) - added by Ozh 6 years ago.
Password can still be pre-filled
user-edit-no-stored-pwd.patch (491 bytes) - added by Ozh 6 years ago.

Download all attachments as: .zip

Change History (7)

@Ozh6 years ago

Password can still be pre-filled

comment:1 follow-up: @westi6 years ago

  • Keywords reporter-feedback added
  • Version set to 2.7

Hmm that is a squirrely fix :-)

What browsers is this an issue in?

comment:2 @kpdesign6 years ago

It happens to me in FF3.0.4. It is also putting my username in the Jabber/GoogleTalk field. I have to clear both fields before saving my profile.

comment:3 in reply to: ↑ 1 @Ozh6 years ago

Replying to westi:

Hmm that is a squirrely fix :-)

What browsers is this an issue in?

Westi: also using FF 3.0.4 Win. The thing is: no matter what OS/browser, the .val('') bit is totally harmless. I just find it a waste that I have to run a little plugin just for this:)

comment:4 @westi6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10046]) Fight back against browser autocomplete some more. Fixes #8462 props Ozh.

comment:5 @azaozz6 years ago

That's nice, but it won't work in many cases, as jQuery(document).ready() would run before the browser has auto-filled the values (as it runs on "domready"). Some similar js is at the bottom of wp-login.php and it has 200ms delay.

Note: See TracTickets for help on using tickets.