support single-lined Template Name comment blocks for Templates

[DD32]

at present, The Template system requires that the Template Names are on their own lines, Eg:

/*
Template Name: Snarfer
*/

Using something such as:

/* Template Name: Snarfer */

or

<?php // Template Name: Snarfer ?>

will result in Snarfer */ and Snarfer ?> respectively.

The attached patch causes the template locator to ignore anything after a closing comment marker(*/) as well as end-php markers(?>)

(As promised for Anthony)

[DD32]

I transposed the minor digits in the patch name.. but rest assured, Its for this ticket.

[Denis-de-Bernardy]

updated and enhanced patch

[westi]

Denis, I take the new patch is intending to apply this rule to all the other headers?

If so, we should create a cleanup function containing the regex call and just call that.

Named something like _cleanup_header_comment() but preferably snapier!

[Denis-de-Bernardy]

done

[westi]

(In [11168]) Support single line Template Name comment blocks for theme Templates and apply same cleanup to all header lines. Fixes #8497 props DD32 and Denis-de-Bernardy.

[Denis-de-Bernardy]

fix potential cron job issues

[Denis-de-Bernardy]

oh, you just committed it. I had noticed a potential potential cron job issue. new patch against current trunk arriving in a sec.

[Denis-de-Bernardy]

the cron that checks for theme updates uses get_themes(), so we need to make sure the function is defined when that gets triggered.

[Denis-de-Bernardy]

fix both themes and plugins update cron

[Denis-de-Bernardy]

there. fixes both the theme and the plugin update check cron -- else we'd get fatal errors when they're triggered from the front end.

[westi]

I think I would prefer to move the new function to wp-includes/functions.php where it will always be available.

[westi]

(In [11170]) Move _cleanup_header_comment() to wp-includes so it is always available. Fixes #8497 props Denis-de-Bernardy.

[peterwilsoncc]

In 47779:

Tests: Add unit tests for _cleanup_header_comment().

Props pbearne.
Fixes #38101. See #8497.