WordPress.org

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#8524 closed enhancement (fixed)

Hooks Needed for WP 2.7 Upgrade Features

Reported by: markedwards Owned by: DD32
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

Seems as though there are no action hooks in place that get called before Wordpress tries to upgrade plugins, themes, and the core itself. In my perspective this is a big oversight that will cause problems down the road and wind up breaking a lot of sites. Some plugins will need to know in advance that an upgrade is about to take place for the plugin itself or the core in order to take appropriate actions that maintain site stability. I can image that the same holds true for many complicated themes. This lack also presents a problem on multi-admin sites - what if one admin inadvertently begins an upgrade without realizing that another admin isn't ready for that to happen? The results could potentially be catastrophic and lead to extended downtime, loss of work, loss of data, etc.

PLEASE include action hooks in all the core upgrade functions BEFORE any file copying/deleting takes place. This will allow a diverse set of safety checks to be put in place by whoever needs them, which will prevent disasters.

I marked this high priority - based on my experiences managing and developing high traffic multi-editor and multi-admin sites I truly think it's warranted and should be handled before 2.7 officially launches. After all, it's just a series of do_action calls - nothing major to get this straightened out.

Change History (7)

#1 @jacobsantos
13 years ago

  • Milestone changed from 2.7 to 2.8

#2 @DD32
13 years ago

  • Priority changed from high to normal
  • Summary changed from Hooks Need for WP 2.7 Upgrade Features To Avoid Disaster! to Hooks Needed for WP 2.7 Upgrade Features

A request for some hooks in the plugin upgrader was requested previously, I've personally been avoiding adding hooks to the upgrader/installer due to needing to consolidate the ever growing number of locations which are using nearly the same code.

In your case of multiple admins, You should probably get admins to schedule times for the upgrades to take place..

I've changed the title to reflect the nature of the ticket rather than a potential problem which could occur.

(Also, Yes, 2.8, Its too late in the release cycle to add it, It'll take some 'discussion' over the best placing for them, among other things. I'm also planning on consolidating the code in 2.8 and adding the hooks then, so probably best to leave it)

#3 @Denis-de-Bernardy
13 years ago

  • Cc Denis-de-Bernardy added

#4 @ryan
13 years ago

  • Component changed from General to Upgrade
  • Owner anonymous deleted

#5 @DD32
13 years ago

  • Owner set to DD32
  • Status changed from new to assigned

#7875 included some hooks.

I'm planning on adding a few more hooks shortly.

#6 @janeforshort
13 years ago

  • Milestone changed from 2.8 to Future Release

Punting due to feature freeze. Reconsider with next release.

#7 @Denis-de-Bernardy
13 years ago

  • Milestone changed from Future Release to 2.8
  • Resolution set to fixed
  • Status changed from assigned to closed

see #7875. please open tickets for specific hooks.

Note: See TracTickets for help on using tickets.