Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#8563 closed defect (bug) (fixed)

Undefined variable: download_file

Reported by: matthewh84's profile matthewh84 Owned by:
Milestone: 2.7 Priority: low
Severity: trivial Version: 2.7
Component: Plugins Keywords:
Focuses: Cc:

Description

/wp-admin/includes/plugin-install.php
r10175

Notice: Undefined variable: download_file in C:\xampplite\htdocs\wptrunk\wp-admin\includes\plugin-install.php on line 843

Line 843 has
if ( is_wp_error($download_file) )

return new WP_Error('download_failed', ('Download failed.'), $download_file->get_error_message());

Should either be
if ( isset($download_file) && is_wp_error($download_file) )

or removed entirely if it isn't needed. I think it isn't needed at all, but I'm not positive on that.

Attachments (1)

plugin-install-remove.patch (550 bytes) - added by matthewh84 17 years ago.
Patch to remove the lines

Download all attachments as: .zip

Change History (3)

#1 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10176]) Remove unneeded lines. Props matthewh84. fixes #8563

@matthewh84
17 years ago

Patch to remove the lines

#2 @matthewh84
17 years ago

You beat me to it. Was working on submitting patch file and you fixed it in that time.

Note: See TracTickets for help on using tickets.