WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8581 closed defect (bug) (fixed)

Tag not closed in theme editor when the file does not have a description

Reported by: roganty Owned by: roganty
Milestone: 2.7.1 Priority: normal
Severity: normal Version: 2.7
Component: UI Keywords: has-patch theme editor ui xhtml
Focuses: Cc:

Description

I've noticed this before problem before, but I didn't think anything of it.

The problem is to do when the file being edited doesn't have a description, the strong tag is not closed in the title.

There are two ways this could be fixed, but they both give different results.

The first way is to add the opening strong tag to the start of the variable $desc_header and to remove the opening strong tag from where the variable is printed to the screen.
If there is no description this fix will not make the file name bold.

The second way is to add the closing strong tag to the end of the variable $desc_header
If there is no description this fix will make the file name bold.

Attachments (2)

theme-editor1.diff (728 bytes) - added by roganty 5 years ago.
Closes tag and removes formatting from file name with no description
theme-editor2.diff (484 bytes) - added by roganty 5 years ago.
Closes tag and keeps formatting for file name with no description

Download all attachments as: .zip

Change History (6)

roganty5 years ago

Closes tag and removes formatting from file name with no description

roganty5 years ago

Closes tag and keeps formatting for file name with no description

comment:1 roganty5 years ago

  • Version set to 2.7

comment:2 azaozz5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10194]) Fix missing closing tag in theme-editor.php, props roganty, fixes #8581

comment:3 ryan5 years ago

  • Milestone changed from 2.8 to 2.7.1

comment:4 ryan5 years ago

(In [10195]) Fix missing closing tag in theme-editor.php, props roganty, fixes #8581 for 2.7

Note: See TracTickets for help on using tickets.