WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#8583 closed defect (bug) (fixed)

If you're using paged coments, 'first' is selected in the options and wp_list_comments is used, then the comment permalinks on the first page will be broken

Reported by: johnconners Owned by:
Milestone: 2.7.1 Priority: normal
Severity: normal Version: 2.7
Component: Comments Keywords:
Focuses: Cc:

Description

Basically, if this set of circumstances is true then the individual comment permalinks will look like this on the first page:

http://localhost/wptrunk/2008/12/this-is-a-post/comment-page-/#comment-12345

Note that the number '1' should appear after 'comment-page-', since it's page 1. This happens since the 'cpage' query parameter isn't set for the first page of comments unless the option to show the latest comments by default is set.

Attached is a patch that fixes the problem.

Attachments (1)

8583.diff (663 bytes) - added by johnconners 7 years ago.

Download all attachments as: .zip

Change History (7)

@johnconners7 years ago

comment:1 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10196]) Fix comment links when displaying first page of comments. Props johnconners. fixes #8583 for trunk

comment:2 @ryan7 years ago

  • Milestone changed from 2.8 to 2.7.1

comment:3 @ryan7 years ago

(In [10197]) Fix comment links when displaying first page of comments. Props johnconners. fixes #8583 for 2.7

comment:4 @Viper007Bond7 years ago

Dang, I thought I tested my bit of code to death. Sorry that slipped in.

comment:5 @kretzschmar6 years ago

  • Keywords has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

If you change the number of comments per page with 'wp_list_comments' the first paginate_comments_links function ABOVE the comments isn't aware of it and is shown.

This is a real problem if newest option is choosen because the user has to switch to the second page before seeing any links at all.

comment:6 @Viper007Bond6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Please open a new ticket rather than reopening this ticket. Your issue is unrelated to this one.

Note: See TracTickets for help on using tickets.