WordPress.org

Make WordPress Core

Opened 18 years ago

Closed 17 years ago

Last modified 4 years ago

#86 closed defect (bug) (fixed)

Plugin Actions do not produce output on bookmarklet.php

Reported by: unteins Owned by: matt
Milestone: Priority: normal
Severity: major Version: 1.2
Component: General Keywords:
Focuses: Cc:

Description

I wrote the attached plugins. LJ Extras should output quite a bit of additional HTML in the bookmarklet.php page. I tested the if statement and it is returning true, so the actions should be added. I am not sure if the actions are not being called on bookmarklet.php or if the add_action call is failing.

I talked with photomatt and he believed that the actions should be called, so I am reporting this as a bug.

Attachments (1)

0000086-ljplugins.zip (14.4 KB) - added by unteins 17 years ago.

Download all attachments as: .zip

Change History (6)

#2 @ryan
18 years ago

  • Status changed from new to assigned

Do you mean the admin_footer action? Since bookmarklet.php does not include admin-footer.php, the do_action for admin_footer is not getting called. bookmarklet.php can either be changed to use admin-footer.php or directly perform the do_action. Can you try one of those and let us know if that fixes it? The easiest approach would probably be to add the following right before the closing body tag.

<?php do_action('admin_footer', ); ?>

#3 @anonymousbugger
18 years ago

Ok, just to be nice I tried what you asked me to and it fixes half of the problem. The Admin Footer actions are now called, but the Admin Head actions still aren't being called. The header of bookmarklet.php is devoid of the data that should be there if Admin Head is being called.

So, this fixes half, but not everything.

#4 @matt
17 years ago

  • fixed_in_version set to 1.5
  • Owner changed from anonymous to matt
  • Resolution changed from 10 to 20
  • Status changed from assigned to closed

Added footer call to bookmarklet.

This ticket was mentioned in Slack in #core-js by gziolo. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.