Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#8611 closed defect (bug) (wontfix)

svn:externals ignored by WordPress.org plugin packager

Reported by: DD32 Owned by: mdawaffe
Milestone: Priority: highest omg bbq
Severity: major Version: 2.7
Component: WordPress.org Site Keywords:
Focuses: Cc:


It appears that svn:externals properties are ignored by the plugin packager, At least for svn:// urls.

Eg: http://svn.wp-plugins.org/revision-control/trunk (While the web interface doesnt display it, It does have a svn external property if you do a checkout) compared to http://downloads.wordpress.org/plugin/revision-control.zip which lacks the 'inc' folder (which is a svn:externals to svn://dd32.id.au/wp-plugin-dd32-common-class/)

I'm pretty sure i've set it up correctly, But it also doesnt show on http://plugins.trac.wordpress.org/browser/revision-control/trunk the same as it does for http://trac.wordpress.org/browser/trunk/wp-content/plugins with the externals, Although i think that might be a Trac setting and completely separate from the problem..

Change History (13)

#1 @DD32
12 years ago

Just a quick update;

Setting it to http://svn.dd32.id.au/wp-plugin-dd32-common-class/ indeed shows it in the Trac Browser as expected, But it still doesnt end up in the zip packages.

Is it a condition whereby only wordpress.org externals are included? Or is it all externals are ignored? I've not yet checked.. It makes it hard to rely upon a helper class/code if the latest version cannot be automatically included in each plugin..

#2 @strider72
12 years ago

  • Cc strider72 added

#3 @Denis-de-Bernardy
11 years ago

  • Cc Denis-de-Bernardy added
  • Milestone set to 2.8
  • Priority changed from normal to high
  • Severity changed from normal to major
  • Version set to 2.7

is this still current?

#4 @DD32
11 years ago

I'll close it when its no longer an issue.

To test if its an issue, Download http://downloads.wordpress.org/plugin/revision-control.zip If it contains the 'inc' folder, then This ticket can be closed, As it is, Its still being ignored.

#5 @Denis-de-Bernardy
11 years ago

it contains an inc folder.

#6 @DD32
11 years ago

it contains an inc folder.

Er... No it doesnt. SVN does, But not the .zip i linked to.. (Well.. The tagged zip's will, since i manually added them, but the trunk zip which relys on svn:externals doesnt)

#7 @Denis-de-Bernardy
11 years ago

Makes one wonder if someone is even reading the wordpress.org and maintaining the site. :D

#8 @Denis-de-Bernardy
11 years ago

  • Milestone changed from 2.8 to Unassigned
  • Priority changed from high to highest omg bbq

#9 @Denis-de-Bernardy
11 years ago

  • Milestone Unassigned deleted

#10 @ryan
11 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

I've been informed that externals are not allowed. Docs are being updated to point that out.

#11 @strider72
11 years ago

  • Summary changed from svn:externals ignored by WordPress.org plugin packager to a good question

"externals are not allowed"

WHY NOT???????

#12 @strider72
11 years ago

  • Summary changed from a good question to svn:externals ignored by WordPress.org plugin packager

#13 @Denis-de-Bernardy
11 years ago

the only reasons that would seem valid would be security and testing (scanning for function name usage for instance).

It's a shame that local externals can't be used, though. If SVN was upgraded to 1.5 or later, you can then add stuff relative to the local root:

my-lib ^/plugins/my-lib/trunk

That clearly poses no security threats. But anyway... We've learned to live without it and use our own SVN instead.

Note: See TracTickets for help on using tickets.