Chunked Decode not completely working

[jacobsantos]

Fixes several issues and ensures that a string is always returned.

[jacobsantos]

Return string only and fix bug with loop.

[jacobsantos]

This should be committed as soon as possible.

[jacobsantos]

It should fix several other issues people have having.

[ryan]

(In [10282]) Chunked decode fixes. Don't return WP_Error for body. Props jacobsantos. see #8618

[ryan]

Milestone for 2.7.1?

[DD32]

re: } while ( true === $done );

why not just change that to while(true) and remove the $done and break, It'll probably only confuse someone in the future..

Well.. Actually, Wait a minute. That change results in the loop only running once, because $done will -never- be true in that loop, well.. it will be.. right before it exits the function.. So, If theres multiple chunks in the document (I swear thats possible, right?) it'll return null from that function now..

[jacobsantos]

Multiple Chunks? WTF? No, I don't think that is in the spec. There can be footer headers after the '0', but that is it.

[jacobsantos]

Replying to ryan:

Milestone for 2.7.1?

Yes, please. Leave the while as it is for it though.

[jacobsantos]

Patch for WordPress 2.7 Branch

[jacobsantos]

Fix for the fix on trunk.

[ryan]

(In [10283]) Chunked decoding fix from jacobsantos. fixes #8618

[ryan]

(In [10284]) Chunked decoding fix from jacobsantos. fixes #8618 for 2.7