category_name query fails for multiple-word sub-categories

[filosofo]

Suppose you have a category named "I am sub category". Its URL looks something like this:

example.com/grandparent/parent/i-am-sub-category/

When you query for the sub-category using category_name, like so

query_posts(array('category_name' => 'I am sub category'));

the query calls get_category_by_path() on 'I am sub category' first with the default of "full match" set to true, which returns null because the full match would include the parent and grandparent category names, as above.

By the time the query gets around to calling get_category_by_path() again, this time with full match set to false, it has stripped the spaces from it, so that it searches for 'iamsubcategory' which it won't find.

The solution is to sanitize the category name from the start so the spaces are handled correctly.

[minusonebit]

See also #8632. I think the submitter is referring to the same thing, but I am unsure.

[markjaquith]

(In [10956]) Sanitize when querying against category name so that multiple-word subcategories match. props filosofo. fixes #8619

[ryan]

(In [11085]) Revert [10956]. fixes #9643 see #8619

[ryan]

This caused #9643, evidently.

[filosofo]

Sorry about that. I was using sanitize_title because that's what get_category_by_path does. However, I'd failed to note that get_category_by_path splits the path into "leaves" delimited by slashes, and sanitizes the leaves individually.

Latest patch does that and corrects the original problem without causing #9643

[ryan]

(In [11121]) Sanitize when querying against category name so that multiple-word subcategories match. props filosofo. fixes #8619