WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#8708 closed defect (bug) (fixed)

Remove paging information from Atom comment feed ids

Reported by: alexforrow Owned by: josephscott
Milestone: 2.7.1 Priority: normal
Severity: normal Version: 2.7
Component: XML-RPC Keywords: comments, feeds, atom
Focuses: Cc:

Description

In WordPress 2.7 the ids of comments in Atom comment feeds have page numbers included.

E.g. http://wordpressnew/2008/12/23/hello-world/comment-page-1/#comment-2

This paging information is clearly not relevant in a feed, and could break things if the the page number were to change (ids should never change).

This patch reverts the id format to that of WordPress 2.6, which does not include paging information.

E.g. http://wordpressnew/2008/12/23/hello-world/#comment-2

Attachments (1)

remove_pagination.diff (1.3 KB) - added by alexforrow 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 alexforrow5 years ago

  • Component changed from General to XML-RPC
  • Milestone 2.8 deleted
  • Owner changed from anonymous to josephscott

comment:2 ryan5 years ago

  • Milestone set to 2.7.1

comment:3 ryan5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10385]) Use guid instead of link for atom comment IDs. fixes #8708 for trunk

comment:4 ryan5 years ago

(In [10386]) Revert accidental bits. see #8708

comment:5 ryan5 years ago

(In [10387]) Use guid instead of link for atom comment IDs. fixes #8708 for 2.7

comment:6 GregMulhauser5 years ago

  • Keywords comments feeds atom added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi folks,

I'm not convinced that this 'bug' is necessarily a bug, or that this 'fix' is necessarily a fix...

I understand that in principle, IDs should never change -- but changing *URIs* are a logical consequence of allowing users to choose 1) comment pagination, and 2) ascending date order to display comments. (URIs do not change if comments are displayed in descending date order and with a constant value for comments per page.) Unfortunately, IDs constructed without page numbers make for broken URIs for all comments except those which happen to live at the post's permalink. In alexforrow's example, the URI only works because we are on comment page 1; if we were on other pages, the URI would be broken.

When submitting the bug report, alexforrow mentioned that including page numbers "could break things if the the page number were to change". But if "break things" means "break the way in which IDs can pass for URIs", then the fix only serves to trade future potential breaks for present guaranteed breaks for users with paging enabled.

I'm guessing that many users would be more unhappy to find that their Atom feeds include broken links than to find that they may break comment URIs if they choose pagination combined with ascending date order.

I'm happy to be told I'm all wrong about this, but it just seemed to me there was more afoot than whether including paging information was a good idea or a bad idea...

All the best,
Greg

comment:7 GregMulhauser5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Whooops -- sorry, my confused brain at work (or not at work, as the case may be)!

Duh: Atom feeds have IDs...AND they have links. Fixing one doesn't mean breaking the other.

Apologies again!

All the best,
Greg

Note: See TracTickets for help on using tickets.