WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 11 months ago

#8714 closed enhancement (fixed)

Ellipses instead of ... in UI

Reported by: janeforshort Owned by:
Milestone: 3.6 Priority: normal
Severity: trivial Version: 2.7
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:

Description

In places where we use [...] to indicate that there's more content, we should use ellipses instead of three periods.

Attachments (10)

patch.diff (34.2 KB) - added by tjsingleton 5 years ago.
patch.2.diff (33.3 KB) - added by jordie23 5 years ago.
8714.diff (26.3 KB) - added by wojtek.szkutnik 4 years ago.
8714.2.diff (31.6 KB) - added by DrewAPicture 2 years ago.
Mostly standardizes …, some whitespacing in affected blocks
8714.3.diff (31.5 KB) - added by SergeyBiryukov 2 years ago.
8714.4.diff (17.5 KB) - added by SergeyBiryukov 2 years ago.
Excluded changes to &#8230
8714.5.diff (16.6 KB) - added by SergeyBiryukov 2 years ago.
Excluded pluggable.php
8714.6.diff (17.2 KB) - added by SergeyBiryukov 23 months ago.
Fixed a couple of misses in class-wp-xmlrpc-server.php and formatting.php
8714.7.diff (12.5 KB) - added by SergeyBiryukov 16 months ago.
8714.8.diff (11.3 KB) - added by SergeyBiryukov 12 months ago.

Download all attachments as: .zip

Change History (49)

tjsingleton5 years ago

comment:1 tjsingleton5 years ago

grepped for "..." and replaced what I found being outputted with "…"

comment:2 ninjaWR5 years ago

  • Keywords has-patch added

comment:3 ryan5 years ago

Line 47 of formatting.php should not change. Some occurrences of ... should be replaced with a period. The ones in wp-login.php, for example. Some error message need to be reworded. "Error in deleting..." for one.

comment:4 coffee2code5 years ago

Also, there seems to be a preference for numbered rather than named entities, so ... should probably be replaced with …

comment:5 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; ellipses has-patch removed
  • Milestone changed from 2.8 to 2.9

bumping to 2.9, since patch needs to be refreshed

jordie235 years ago

comment:6 jordie235 years ago

  • Keywords has-patch added; needs-patch removed

Similar patch as before, uses numeric entities, ellipses are removed from certain phrases where they shouldn't exist and the 3 periods are left unchanged on line 47 of formatting.php.

comment:7 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.9 to Future Release

comment:8 wojtek.szkutnik4 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch gsoc added; needs-patch removed

wojtek.szkutnik4 years ago

comment:9 RyanMurphy4 years ago

Possible for 3.1?

comment:10 jane2 years ago

  • Milestone changed from Future Release to 3.4

Is the latest patch good to go? It's embarrassing that this little thing still hasn't been fixed. I didn't mention it in the original ticket, but this flaw was called out by Chris Messina when he was a participant in 2.7 testing.

comment:11 nacin2 years ago

Ellipses should either be part of a translated string (as many are here), or if used as part of text, should be __( '…' ) for translators. (We currently do '…' for translators, but we can standardize either way.)

comment:12 azaozz2 years ago

Agreed, best to be either one or the other. Also worth mentioning that we shouldn't use HTML entities in JS strings like the translated strings in script-loader.

comment:13 SergeyBiryukov2 years ago

  • Keywords needs-refresh added

comment:14 follow-up: DrewAPicture2 years ago

  • Cc xoodrew@… added

Semi-Related #7098 (attachment:ticket:7098:8230-to-hellip.patch)

Working on a refresh.

comment:15 GaryJ2 years ago

  • Cc gary@… added

DrewAPicture2 years ago

Mostly standardizes …, some whitespacing in affected blocks

comment:16 DrewAPicture2 years ago

  • Keywords needs-refresh removed

After some discussion in IRC, settled on … over … and '...' as it was already pretty widely used in Core. Refreshed patch attached for 3.4.

Last edited 2 years ago by DrewAPicture (previous) (diff)

comment:17 ramiy2 years ago

  • Cc r_a_m_i@… added

comment:18 nacin2 years ago

  • Keywords commit added; gsoc removed

Looks good. We need to audit these though, for context (making sure they aren't escaped, for example).

Should probably avoid changing 8230 to hellip if only to not break all of those strings.

comment:19 in reply to: ↑ 14 ramiy2 years ago

Replying to nacin:

Should probably avoid changing 8230 to hellip if only to not break all of those strings.

Nacin, this ticket was created 3 years ago. I think that if we already addressing the issue, we should fix the 8230 as well.

comment:20 nacin2 years ago

  • Keywords needs-refresh added; commit removed

Patch is stale. Can someone refresh it?

SergeyBiryukov2 years ago

comment:21 SergeyBiryukov2 years ago

  • Keywords needs-refresh removed

SergeyBiryukov2 years ago

Excluded changes to &#8230

SergeyBiryukov2 years ago

Excluded pluggable.php

comment:22 ryan2 years ago

  • Keywords early added
  • Milestone changed from 3.4 to Future Release

comment:23 jane2 years ago

Breaking strings in an update is to be expected when the fix is text related. Since this just got punted again, when it goes in eventually, let's not not water it down.

SergeyBiryukov23 months ago

Fixed a couple of misses in class-wp-xmlrpc-server.php and formatting.php

comment:24 SergeyBiryukov23 months ago

Closed #17608 as a duplicate.

Related: #7098, #9030, #13341, #14225

comment:25 helen16 months ago

  • Component changed from UI to Text Changes
  • Keywords needs-refresh added; early removed
  • Milestone changed from Future Release to 3.6

SergeyBiryukov16 months ago

comment:26 SergeyBiryukov16 months ago

  • Keywords needs-refresh removed

Skipped the changes in wp-admin/network.php, didn't look good in the <code> tag.

wp-includes/deprecated.php should probably also be skipped.

comment:27 follow-ups: markjaquith15 months ago

Agree on skipping wp-includes/deprecated.php.

The ones at the ends of error messages should probably change to single periods (as Ryan noted up at comment 3).

Lastly don't we need to avoid using named entities in an XML context?

comment:28 jane15 months ago

Agreed with no ellipses at the end of error messages.

comment:29 in reply to: ↑ 27 ; follow-up: ramiy15 months ago

Don't agree on skipping wp-includes/deprecated.php.

Skipping depricated strings will only make more simmilar strings and make the transtation file larger.

(Related: #18218, #14039, #7098 and many more)

comment:30 in reply to: ↑ 27 GaryJ15 months ago

Replying to markjaquith:

Lastly don't we need to avoid using named entities in an XML context?

For polyglot markup, yes, and note the W3C Recommendation that numbered entities SHOULD use the hexadecimal form when it exists.

comment:31 in reply to: ↑ 29 SergeyBiryukov15 months ago

Replying to ramiy:

Skipping depricated strings will only make more simmilar strings and make the transtation file larger.

The strings in question are not translatable, see lines 1707 and 1734:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/deprecated.php#L1707

comment:32 DrewAPicture12 months ago

8714.7.diff miraculously still applies cleanly. Seems like the consensus is that this should happen early in a cycle so maybe punt (again) to 3.7 early?

comment:33 SergeyBiryukov12 months ago

  • Keywords 3.7-early added
  • Milestone changed from 3.6 to Future Release

comment:34 follow-up: jenmylo12 months ago

It is downright embarrassing that something like this should take us ten versions to do. Chris Messina has mocking rights on me/us for the rest of eternity; I told him back in 2008 that we'd get this fixed before we launched 2.7 (he discovered it during usability testing before beta).

comment:35 in reply to: ↑ 34 Denis-de-Bernardy12 months ago

Replying to jenmylo:

It is downright embarrassing that something like this should take us ten versions to do.

*Rubs Eyes*...

*Chokes*...

[Caugh! Caugh!]

*Pinches himself... Looks around...*

Did you actually write that, Jane? :-D

comment:36 SergeyBiryukov12 months ago

  • Keywords commit added; 3.7-early removed
  • Milestone changed from Future Release to 3.6

Moving back to 3.6 per the IRC chat.

SergeyBiryukov12 months ago

comment:37 SergeyBiryukov12 months ago

Refreshed in 8714.8.diff:

  1. Skipped deprecated.php and "Hello World" post content.
  2. Changed the instances in error messages to single periods, per comment:27.
  3. Used numeric entities in XML content, also per comment:27.

comment:38 SergeyBiryukov12 months ago

In 24207:

Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.

comment:39 SergeyBiryukov11 months ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.