WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#8720 closed defect (bug) (fixed)

Screen icon shown twice on Import page

Reported by: DD32 Owned by: westi
Milestone: 2.9 Priority: low
Severity: minor Version: 2.7
Component: UI Keywords: has-patch, tested
Focuses: Cc:

Description

Under 2.7, When you import a WordPress export, The first step (After the uploading of the xml) has 2 headings: "Import WordPress" & "Assign Authors", Both of these have the Tools icon before them.

Attachments (1)

8720.diff (761 bytes) - added by MattyRob 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 azaozz5 years ago

There are several places where H2s are used both as page title and as subtitle, perhaps we should change the subtitles to H3s.

Also there seem to be few H2s that could either be page titles or subtitles, depending on the different "steps". This happens in few importers, in update core and in plugin update. Since the icon is loaded by a small function in template.php, we could use a global and output it only once per page load.

Perhaps it would be better to have a consistent title (H2 and icon) for all pages that have multiple "steps", then have proper subtitles (H3) for each step.

comment:2 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.7.2 to Future Release

comment:3 Denis-de-Bernardy5 years ago

  • Milestone changed from Future Release to 2.9
  • Priority changed from normal to low
  • Severity changed from normal to minor

comment:4 MattyRob5 years ago

  • Keywords has-patch tested 2nd-opinion added; needs-patch removed

Is this not more to do with the screen_icon() calls the precede the headings? The attached patch seems to fix things nicely and I can only find one call to this function in the other importer scripts.

MattyRob5 years ago

comment:5 westi5 years ago

  • Owner set to westi
  • Status changed from new to reviewing

comment:6 MattyRob4 years ago

  • Keywords 2nd-opinion removed

comment:7 MattyRob4 years ago

Updating this to a commit candidates - it's a very disheartening situation when seeming good patches are apparently ignored. It does not motivate me to look at more.

comment:8 westi4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

(In [12178]) Remove the extra screen icons from the WordPress importer. Fixes #8720 props MattyRob.

Note: See TracTickets for help on using tickets.