WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#8725 closed defect (bug) (fixed)

Redirects not working on Expression Web 2

Reported by: thomasvsundert Owned by: westi
Milestone: 2.8 Priority: normal
Severity: normal Version: 2.7
Component: General Keywords: has-patch tested reporter-feedback
Focuses: Cc:

Description

The global variable $is_IIS checks if the server is an IIS server or not. This has consequences for the way redirects etc. are implemented. The Expression Web software from Microsoft also uses an IIS-based development server, but here the value of
<nowiki>$_SERVERSERVER_SOFTWARE?</nowiki> is 'ExpressionDevServer'. Since all of the 'hacks' specific to IIS also apply to the Expression Web server, the check for IIS should also check for it.

$is_IIS = (strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS') !== false || 
strpos($_SERVER['SERVER_SOFTWARE'], 'ExpressionDevServer') !== false) ? true : false;

Attachments (2)

8725.diff (956 bytes) - added by DD32 6 years ago.
8725.patch (1.2 KB) - added by peaceablewhale 6 years ago.

Download all attachments as: .zip

Change History (8)

@DD326 years ago

comment:1 @DD326 years ago

  • Keywords has-patch commit added

Attached patch based off reporters information.

Untested against Expression server

Removes some unneeded brackets and ditches the ? true : false; since thats exactly what the expression resolves to anyway.

comment:2 @DD326 years ago

Traction? Testing?

I tested the logic, and it seems fine.

comment:3 @westi6 years ago

  • Keywords needs-testing added; commit removed
  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Needs testing on a real ExpressionWeb server.

comment:4 @Denis-de-Bernardy6 years ago

  • Keywords reporter-feedback added
  • Milestone changed from 2.8 to Future Release

punting to future, from lack of reporter-feedback

@peaceablewhale6 years ago

comment:5 @peaceablewhale6 years ago

  • Keywords tested added; needs-testing removed
  • Milestone changed from Future Release to 2.8

A new patch which was tested with Expression Web 2 has been uploaded.

comment:6 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [11379]) Recognize Expression Web 2 as IIS. Props peaceablewhale, DD32. fixes #8725

Note: See TracTickets for help on using tickets.