WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#8744 closed enhancement (wontfix)

Few validation fixes for WordPress

Reported by: Simek Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.8
Component: Validation Keywords: has-patch
Focuses: Cc:

Description

All changes were tested on my Test Blog.

Changelog

Files:

  • wp-login.php
  • login.css

Validation warning:

  • Same ID fo CSS file LINK and login DIV

Solution:

  • DIV ID changed from "login" to "loginbox". CSS also corrected.

File:

  • dashboard.php

Validation warning:

  • FORM ID and NAME attribute value mismatch

Solution:

  • FORM NAME changed to "quick-press"

File:

  • upload.php

Validation warning:

  • Invalid paragraph content or empty paragraph

Solution:

  • Deleted P tag and P close tag. In this P was DIV with Edit, Delete and View options. P tag was unneeded.

File:

  • tools.php

Validation warning:

  • A tag escaping malformed URI reference

Solution:

  • changed HREF to "#" and added ONCLICK attribute for JS script.

Attachments (1)

validation_fixes.patch (4.2 KB) - added by Simek 7 years ago.

Download all attachments as: .zip

Change History (9)

@Simek7 years ago

comment:1 follow-up: @DD327 years ago

tools.php

That'll break Press This.

Press This is designed to be used as a bookmarklet, for that to work, the JavaScript needs to be within the href

comment:2 in reply to: ↑ 1 @Simek7 years ago

Replying to DD32
So why it works for me?

comment:3 @DD327 years ago

So why it works for me?

Clicking it will, But bookmarking it wont, Nor will draging it onto a menu.

Bookmarks remember a URL, not a onclick method.

comment:4 @Simek7 years ago

Publishing also works, but after this explanation I must agree with you.

comment:5 @ryan6 years ago

  • Component changed from General to Validation
  • Owner anonymous deleted

comment:6 @FFEMTcJ6 years ago

  • Milestone changed from 2.7.2 to 2.8

Postponing enhancements to 2.8

comment:8 @ryan6 years ago

  • Milestone 2.8 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Sounds like it. If not, reopen.

Note: See TracTickets for help on using tickets.