get_permalink() bug

[Denis-de-Bernardy]

I presume this bug has been around for quite a while...

If you define WP_HOME in the wp-config file to, say, ​http://localhost/blah/

then permalinks end up like:

​http://localhost/blah//structure

The issue is the way they're defined in the get_permalink() function:

$permalink = get_option('home') . str_replace($rewritecode, $rewritereplace, $permalink);

this should be:

$permalink = rtrim(get_option('home'), '/') . '/', ltrim(str_replace($rewritecode, $rewritereplace, $permalink), '/');

no?

[Denis-de-Bernardy]

$permalink = rtrim(get_option('home'), '/') . '/' . ltrim(str_replace($rewritecode, $rewritereplace, $permalink), '/');

even... but you probably got the point.

[Denis-de-Bernardy]

oh, and the trailing slash is important on ​http://localhost/blah/ to reproduce.

[Denis-de-Bernardy]

along the same lines, the wp-login.php link becomes completely broken:

​http://localhost//wp-login.php?redirect_to=http%3A%2F%2Flocalhost%2Fwp-admin%2F

this essentially forbids any login, presumably due to the cookie path. surely there is something wrong in there.

[DD32]

Surely the issue at fault here, Is that its being defined in the first place with a trailing slash? in which case, people need to read the docs more closely before defining it, Its exactly the same in the admin panel i believe.

eitherway, an untrailingslashit() in the get_option override filter should work well..

[Denis-de-Bernardy]

Btw, I initially ran into the bug when I tried adding a filter to option_home.

add_filter('option_home', 'user_trailingslashit', 30);

It seemed to make more sense that way, since ​http://www.domain.com gets redirected by the canonical url stuff to ​http://www.domain.com/ when the permalink structure has a trailing /.

[Denis-de-Bernardy]

PS: an untrailingslashit() in the overrides makes it work as expected.

[Denis-de-Bernardy]

or then, the _config_wp_home() and _config_wp_siteurl() functions should be documented in such a way that users don't try to add a trailing slash.

[jacobsantos]

Denis-de-Bernardy:

You don't need anyone's permission to create a patch. _config_wp_home() and _config_wp_siteurl() are basically private functions to WordPress, so I'm unsure what documenting them to include what you say would help. The documentation you are talking about should be located where it seems most logical.

[Denis-de-Bernardy]

I think we can close this one as invalid.

I bumped into a separate, double-slash bug on a customer's site. It seemed related to his using a /category/postname.htm structure. Some posts would then get a double-slash for no obvious reason. But I failed to reproduce it on my end. (I'll open a new ticket if I run into it again.)