Make WordPress Core

Opened 21 years ago

Closed 21 years ago

#877 closed defect (bug) (fixed)

Front page doesn't say comments are off even if comments are unchecked

Reported by: carlbanks's profile CarLBanks Owned by: matt's profile matt
Milestone: Priority: normal
Severity: minor Version: 1.5
Component: Administration Keywords:
Focuses: Cc:

Description

When you hit publish it doesn't say comments are off even when you turn off comments and trackbacks. If you go back and edit the page manually it then correctly says the state. This time it's just saying the wrong state on the frontpage. The comments are off when you visit the comments area.

Attachments (1)

post.php.diff (1.0 KB) - added by CarLBanks 21 years ago.

Download all attachments as: .zip

Change History (6)

#1 @CarLBanks
21 years ago

  • Patch set to No

#2 @tuxp3
21 years ago

cosmetic thing, its just a minor "display a useless link" thing

#3 @anonymousbugger
21 years ago

Same problem here. Reproducable.

#4 @MC_incubus
21 years ago

  • Owner changed from anonymous to matt
  • Patch changed from No to Yes
  • reproducibility changed from 70 to 10
  • Resolution changed from 10 to 20
  • Status changed from new to assigned

Only happens when you default to the Advanced view and publish without saving first.

in /wp-admin/post.php on lines 68 through 73 (this is within case 'publish'), a default ping/comment status is only set if coming from the basic write page, and not from the "advanced" write page. Thus, if you have "advanced" mode turned on by default and save a post with comments or pings off, they get set as blank values in the database. In "advanced" mode, empty $ping_status and $comment_status values should mean that comments/pings are CLOSED.

Uploaded patch fixes it. I have tested comments on/off in basic/advanced mode and it works as expected.

#5 @ryan
21 years ago

  • fixed_in_version set to 1.5.1
  • Status changed from assigned to closed

@CarLBanks
21 years ago

Note: See TracTickets for help on using tickets.