Numbers in quotation marks get wrong smart quotes

[filosofo]

Have a number in quotation marks, such as "12345" or '12345' and wptexturize converts the right quotation mark to double-prime and prime marks, respectively.

Patch fixes.

[mrmist]

Probably a dupe see also #7754 #4539 #3810 #4116 #1258

There neeeds to be a big old wp_texturize fix task or something.

[ryan]

see #4491

[mrmist]

Update against current trunk

[mrmist]

Updated patch. Tested with numbers and single/double quotes. Seems to work. doesn't appear to break anything else, so marking as tested. Comitting would seem the fastest way of geting more test exposure.

[Denis-de-Bernardy]

+1

[Denis-de-Bernardy]

are there any unit tests on wptexturize?

[Denis-de-Bernardy]

or at least, known, funky test cases to watch for?

[azaozz]

Replying to Denis-de-Bernardy:

are there any unit tests on wptexturize?

Seems like this needs more testing with non-latin languages.

[Denis-de-Bernardy]

k... moving this over to i18n then. I wouldn't know what to test on this front. :-)

D.

[azaozz]

Also see #3810.

[Denis-de-Bernardy]

punting pending unit tests... even though, like the one wpautop one I just punted, I think this should get committed outright.

[janeforshort]

Punting b/c no tests done in 6 months and we're in beta.

[filosofo]

Let's be realistic.

[Viper007Bond]

It's still a valid issue. Just because progress isn't being made isn't reason enough to close the ticket.

[Denis-de-Bernardy]

Replying to Viper007Bond:

It's still a valid issue. Just because progress isn't being made isn't reason enough to close the ticket.

Any chances you've got a patch? :-)

[filosofo]

We have a patch. It's the prerequisite wptexturize unit tests that are missing.

[nacin]

​http://unit-tests.trac.wordpress.org/changeset/757

[aliso]

Quotation mark fix for most recent code in formatting.php

[aliso]

It looks like the previous patch won't work with the code change from [19795]. I attached a patch that fixes it in the most recent code.

This also solves part 1 of #16957 (same bug).

[MikeHansenMe]

screenshot of problem

[MikeHansenMe]

screenshot after patch

[MikeHansenMe]

Updated patch path relative from wp folder

[MikeHansenMe]

aliso's patch works for me. I updated the patch path and included some screenshots of the problem.

[SergeyBiryukov]

Related: #22971

[aliso]

Any idea when this fix can make it into core? The unit tests should be the same as in ​http://unit-tests.trac.wordpress.org/changeset/757, right?

[miqrogroove]

What is this intended output for these examples?

I need 4 x 20'=80' of trim.

The best year "was that time in 2012" when everyone partied, he said.

[miqrogroove]

I recommend narrowing the focus of this patch so that it will not affect text other than numbers surrounded by quotes preceded by spaces. Examples:

"2004"
'27'
The answer is "42".

Numbers at the beginning or ending of quoted phrases have ambiguous meaning if we want to keep using the primes logic.

[miqrogroove]

#14491 was marked as a duplicate.

[miqrogroove]

#16957 was marked as a duplicate.

[miqrogroove]

New patch against trunk should be much closer to what we need. In miqro-8775.patch:

• Quoted numbers preceded by spaces get curly quotes.
• So, "123" works, but"123"blah does not work.
• Trailing space not required. Will this break things like '99's?
• Decimals and commas are allowed after the first digit.
• nbsp works as whitespace.
• Regexp will search for quotes first for optimum performance.
• Unit tests updated to match.

[miqrogroove]

This will also break the assertion for 'Class of '99', but that is highly ambiguous.

[wonderboymusic]

In 28721:

Fix curly quotes around numbers when applicable.

Adds unit tests.

Props filosofo, mrmist, aliso, MikeHansenMe, miqrogroove.
Fixes #8775.

[miqrogroove]

Reopen to discuss and update the broken unit test for

Class of '99's

See also #26850.

The main question is which patterns should have priority when an apostrophe preceeds exactly two digits.

[miqrogroove]

This is fixed now.

[coreygilmore]

Was there a regression for this (possibly related to #26850)? This is still an issue on trunk and wordpress.com, as seen here:
​http://variety.com/2014/film/news/how-to-train-your-dragon-2-tops-foreign-box-office-after-china-debut-1201284893/
​http://variety.com/2014/digital/news/expendables-3-illegally-downloaded-5-million-times-but-still-isnt-top-hit-for-pirates-1201285179/
​http://coreygilmore.wordpress.com/2014/08/18/expendables-3-illegally-downloaded-5-million-times-but-still-isnt-top-hit-for-pirates/

[helen]

Reopening for investigation.

[miqrogroove]

coreygilmore: You are seeing the prime and double-prime logic there. It hasn't changed.

[helen]

Apparently this was for numbers-only within quotes.

[miqrogroove]

Same situation as https://core.trac.wordpress.org/ticket/4539#comment:57

Several different bugs were brought up in comments but never really had a whole ticket just for "Primes vs. Quotes Ending With Digits". That is its own can of worms.

Make a new ticket if desired.