WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#8785 closed defect (bug) (fixed)

2.7 new press-this closes the pictures after picking one

Reported by: BrianTokyo Owned by: noel
Milestone: 2.9 Priority: normal
Severity: major Version: 2.7
Component: Press This Keywords: needs-patch
Focuses: Cc:

Description

Since 2.7 whenever I pick a picture on the pictures box, it closes, so if I want to pick another one I have to open that box again and the whole thing reloads, making this useless (or very annoying/time consuming) if you want to use more than 1 picture.

Attachments (5)

press-this-5-12-7pm.patch (3.9 KB) - added by noel 5 years ago.
Fixes multiple issues, including layout, and image selection UI
press-this-6-9.patch (3.5 KB) - added by noel 5 years ago.
For rev 11538
press-this-css-tweaks-6-9.patch (3.7 KB) - added by noel 5 years ago.
some css tweaks
press-this-full-patch.patch (5.0 KB) - added by noel 5 years ago.
press-this-2.8-final-patch.patch (5.6 KB) - added by noel 5 years ago.
actual final patch

Download all attachments as: .zip

Change History (14)

comment:1 follow-up: BrianTokyo5 years ago

Noticed this isn't fixed yet in the nightly builds. Is this change to press-this done in purpose?

comment:2 DD325 years ago

  • Keywords needs-patch added; press this pictures removed
  • Milestone set to 2.8

comment:3 in reply to: ↑ 1 Denis-de-Bernardy5 years ago

  • Milestone changed from 2.8 to Future Release

Replying to BrianTokyo:

Noticed this isn't fixed yet in the nightly builds.

Because there is no patch

Is this change to press-this done in purpose?

Probably not. It must have crept into the code base when #7949 was looked into.

comment:4 Denis-de-Bernardy5 years ago

  • Severity changed from critical to normal

noel5 years ago

Fixes multiple issues, including layout, and image selection UI

comment:6 noel5 years ago

  • Keywords has-patch added; needs-patch removed

noel5 years ago

For rev 11538

noel5 years ago

some css tweaks

noel5 years ago

noel5 years ago

actual final patch

comment:7 Denis-de-Bernardy5 years ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 2.9
  • Severity changed from normal to major

comment:8 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

r11540 broke the css tweaks in patch, else works great.

comment:9 ryan4 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.