WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8787 closed defect (bug) (fixed)

Error in URL checking in http.php

Reported by: mercurix Owned by:
Milestone: 2.7.1 Priority: normal
Severity: critical Version: 2.7
Component: HTTP API Keywords: has-patch commit
Focuses: Cc:

Description

There is a bug in wp-includes/http.php in the 2.7 release.
In line 753 it reads:

if ( 'http' != $arrURLscheme?
'https' != $arrURLscheme? )

What should be there instead is:

if ( 'http' != $arrURLscheme? && 'https' != $arrURLscheme? )

Without this fix Wordpress will fail to call its wp-cron.php (and leading to a crash with seg fault for me) if the Wordpress installation is on an https server and cannot be reached with http.

Attachments (1)

8787.diff (2.6 KB) - added by jacobsantos 6 years ago.
Some documentation and the other fix.

Download all attachments as: .zip

Change History (10)

comment:1 @jacobsantos6 years ago

  • Component changed from General to HTTP
  • Owner anonymous deleted

comment:2 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10309]) And instead of or. Props mercurix. fixes #8787 for trunk

comment:3 @ryan6 years ago

(In [10310]) And instead of or. Props mercurix. fixes #8787 for 2.7

comment:4 @jacobsantos6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 @jacobsantos6 years ago

This is in two locations. You fixed the first one, the second one needs to be corrected as well.

comment:6 @jacobsantos6 years ago

Found in line ~633 also.

@jacobsantos6 years ago

Some documentation and the other fix.

comment:7 @jacobsantos6 years ago

  • Keywords has-patch commit added

Patch fixes the other location as well as adds some inline documentation.

comment:8 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10320]) Fix URL checking and add phpdoc. Props jacobsantos. fixes #8787 for trunk

comment:9 @ryan6 years ago

(In [10321]) Fix URL checking and add phpdoc. Props jacobsantos. fixes #8787 for 2.7

Note: See TracTickets for help on using tickets.