Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#8787 closed defect (bug) (fixed)

Error in URL checking in http.php

Reported by: mercurix Owned by:
Priority: normal Milestone: 2.7.1
Component: HTTP API Version: 2.7
Severity: critical Keywords: has-patch commit
Cc: Focuses:

Description

There is a bug in wp-includes/http.php in the 2.7 release.
In line 753 it reads:

if ( 'http' != $arrURLscheme
'https' != $arrURLscheme )

What should be there instead is:

if ( 'http' != $arrURLscheme && 'https' != $arrURLscheme )

Without this fix Wordpress will fail to call its wp-cron.php (and leading to a crash with seg fault for me) if the Wordpress installation is on an https server and cannot be reached with http.

Attachments (1)

8787.diff​ (2.6 KB ) - added by jacobsantos 18 years ago.
Some documentation and the other fix.

Download all attachments as: .zip

Change History (10)

#1 @jacobsantos
18 years ago

  • Component General → HTTP
  • Owner anonymous removed

#2 @ryan
18 years ago

  • Resolution → fixed
  • Status new → closed

(In [10309]) And instead of or. Props mercurix. fixes #8787 for trunk

#3 @ryan
18 years ago

(In [10310]) And instead of or. Props mercurix. fixes #8787 for 2.7

#4 @jacobsantos
18 years ago

  • Resolution fixed
  • Status closed → reopened

#5 @jacobsantos
18 years ago

This is in two locations. You fixed the first one, the second one needs to be corrected as well.

#6 @jacobsantos
18 years ago

Found in line ~633 also.

@jacobsantos
18 years ago

Some documentation and the other fix.

#7 @jacobsantos
18 years ago

  • Keywords has-patch commit added

Patch fixes the other location as well as adds some inline documentation.

#8 @ryan
18 years ago

  • Resolution → fixed
  • Status reopened → closed

(In [10320]) Fix URL checking and add phpdoc. Props jacobsantos. fixes #8787 for trunk

#9 @ryan
18 years ago

(In [10321]) Fix URL checking and add phpdoc. Props jacobsantos. fixes #8787 for 2.7

Note: See TracTickets for help on using tickets.