wp_mkdir_p doesn't work with safe mode enabled

[remi]

The wp_mkdir_p function (which is used by many WP features like media uploading) doesn't work when PHP's safe-mode is enabled because it allows trailing slashes at the end of the directories it tries to create.

Adding this code at the beginning of the function solves the problem:

if (substr($target, -1) == "/") {
  $target = substr($target, 0, -1);
}

[Denis-de-Bernardy]

I'm not 100% this won't have side effects

[Denis-de-Bernardy]

punting pending tests

[Denis-de-Bernardy]

$target = / is problematic.

[Denis-de-Bernardy]

see also #10497

[scribu]

Patch should use untrailingslashit().

[dd32]

perhaps this should be added instead:

$target = untrailingslashit($target); 
if ( empty($target) )
  $target = '/';

[dd32]

also, this is a defect, It doesnt operate correctly under safe mode.

[ryan]

Replying to dd32:

perhaps this should be added instead:

$target = untrailingslashit($target); 
if ( empty($target) )
  $target = '/';

Sounds good.

[automattor]

(In [12740]) Fix wp_mkdir_p() when running under safe_mode on certain PHP versions. Props Denis-de-Bernardy. Fixes #8830