invalid XHTML markup in get_search_form function in general-template.php

[jcraig90210]

Old function:

function get_search_form() {

do_action( 'get_search_form' );

if ( != locate_template(array('searchform.php'), true) )

return;

$form = '<form method="get" id="searchform" action="' . get_option('home') . '/" >
<label class="hidden" for="s">' . ('Search') . '</label>
<div><input type="text" value="' . attribute_escape(apply_filters('the_search_query', get_search_query())) . '" name="s" id="s" />
<input type="submit" id="searchsubmit" value="'.attribute_escape(('Search')).'" />
</div>
</form>';

echo apply_filters('get_search_form', $form);

}

New Function:

function get_search_form() {

do_action( 'get_search_form' );

if ( != locate_template(array('searchform.php'), true) )

return;

$form = '<form method="get" id="searchform" action="' . get_option('home') . '/" >
<div><label class="hidden" for="s">' . ('Search') . '</label>
<input type="text" value="' . attribute_escape(apply_filters('the_search_query', get_search_query())) . '" name="s" id="s" />
<input type="submit" id="searchsubmit" value="'.attribute_escape(('Search')).'" />
</div>
</form>';

echo apply_filters('get_search_form', $form);

}

[jcraig90210]

Forgot to add. This corrects the fact that the search form doesn't validate according to XHTML standards. Will be correct for standard HTML as well.

[azaozz]

(In [10356]) Fix invalid HTML in get_search_form(), props jcraig90210, fixes #8851