WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#8868 closed defect (bug) (fixed)

Excessively assertive messages in plugin installer

Reported by: Ozh Owned by: DD32
Milestone: 2.7.2 Priority: normal
Severity: normal Version: 2.7
Component: Plugins Keywords: has-patch commit dev-feedback
Focuses: Cc:

Description

The plugin installer has excessive messages.

Example: "Warning: This plugin has not been tested with your current version of WordPress." shows when the "tested up to:" field is missing, while this may be totally deliberate to omit this field.

Assertions should be only:

  • "has not been tested" if "tested up to" < $wp_version.
  • "is not compatible" if "requires" > $wp_version

In other cases, messages should not be this positive.

Suggestions:

  • Don't show the warning when "tested up to" is missing
  • ignore minor WP version number since they're very unlikely to change a plugin behavior
  • be less assertive: "This plugin might or might not have been tested"

wp-hacker thread, for reference: http://comox.textdrive.com/pipermail/wp-hackers/2009-January/023774.html

Attachments (1)

8868.diff (1.7 KB) - added by DD32 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 @DD326 years ago

  • Owner changed from dd32 to DD32
  • Status changed from new to assigned

@DD326 years ago

comment:3 @DD326 years ago

  • Keywords has-patch added; plugins plugins-installer removed

attachment 8868.diff added.

  • If a version is null(not specified), Then the message will not be shown, So if a plugin neglects to mention its tested up to value, the "Not tested" message will not be shown
  • Same as above, but for the required value
  • It only checks the same length version as the plugin specifies.
    • The version checking is only as specific as the plugins readme states:
    • If The plugin specified its tested up to "2.7" then a WP version of "2.7.1" will NOT trigger the "not tested" message
    • If The plugin specified a specific version "2.7.1", then a WP version of "2.7.2" WILL trigger the "not tested" message
  • Slight change to the bolding of the required message (bold the phrase rather than the "compatible" word)
  • String changes to reflect more closely the nature of the update are not in this patch, I'll leave it open for discussion of what the appropriate phrasing would be.

comment:4 @DD326 years ago

  • Keywords commit dev-feedback added

comment:5 @ryan6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10759]) Cleanup plugin compatibility messages. Props DD32. fixes #8868

Note: See TracTickets for help on using tickets.